deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fix :hidden selector that was accidentally reverted in previous commit, also fixed tests for :hidden selector in IE6

Browse source
This commit is contained in:
Brandon Aaron 2009-05-04 00:19:57 +00:00
parent d72b8307de
commit 31b573185b
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/selector.js
View file

@ -977,7 +977,7 @@ jQuery.expr = Sizzle.selectors;
jQuery.expr[":"] = jQuery.expr.filters; jQuery.expr[":"] = jQuery.expr.filters;
Sizzle.selectors.filters.hidden = function(elem){ Sizzle.selectors.filters.hidden = function(elem){
return elem.offsetWidth === 0 || elem.offsetHeight === 0; return elem.offsetWidth === 0 && elem.offsetHeight === 0;
}; };
Sizzle.selectors.filters.visible = function(elem){ Sizzle.selectors.filters.visible = function(elem){

3
test/unit/selector.js
View file

@ -364,6 +364,7 @@ test("pseudo (:) selectors", function() {
t( "Is Hidden", "#dl:hidden", ["dl"] ); t( "Is Hidden", "#dl:hidden", ["dl"] );
var $div = jQuery('#nothiddendivchild'); var $div = jQuery('#nothiddendivchild');
$div.css({ fontSize: 0, lineHeight: 0 });// IE also needs to set font-size and line-height to 0
$div.width(0).height(0); $div.width(0).height(0);
t( "Is Hidden", '#nothiddendivchild:hidden', ['nothiddendivchild'] ); t( "Is Hidden", '#nothiddendivchild:hidden', ['nothiddendivchild'] );
t( "Is Not Hidden", '#nothiddendivchild:visible', [] ); t( "Is Not Hidden", '#nothiddendivchild:visible', [] );
@ -376,7 +377,7 @@ test("pseudo (:) selectors", function() {
$div.width(1).height(1); $div.width(1).height(1);
t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] ); t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] );
t( "Is Not Visible", '#nothiddendivchild:hidden', [] ); t( "Is Not Visible", '#nothiddendivchild:hidden', [] );
$div.width('').height(''); $div.width('').height('').css({ fontSize: '', lineHeight: '' });
t( "Check position filtering", "div#nothiddendiv:eq(0)", ["nothiddendiv"] ); t( "Check position filtering", "div#nothiddendiv:eq(0)", ["nothiddendiv"] );
t( "Check position filtering", "div#nothiddendiv:last", ["nothiddendiv"] ); t( "Check position filtering", "div#nothiddendiv:last", ["nothiddendiv"] );