deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Coerce s.url to string before calling replace, since replace is also a method of a Location object. Fixes #7531.

Browse source
This commit is contained in:
Colin Snover 2010-11-17 00:59:24 -06:00
parent 0838bdf52c
commit 2a0c7d702b
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ajax.js
View file

@ -198,7 +198,10 @@ jQuery.extend({
var s = jQuery.extend(true, {}, jQuery.ajaxSettings, origSettings), var s = jQuery.extend(true, {}, jQuery.ajaxSettings, origSettings),
jsonp, status, data, type = s.type.toUpperCase(), noContent = rnoContent.test(type); jsonp, status, data, type = s.type.toUpperCase(), noContent = rnoContent.test(type);
s.url = s.url.replace( rhash, "" ); // toString fixes people passing a window.location or
// document.location to $.ajax, which worked in 1.4.2 and
// earlier (bug #7531). It should be removed in 1.5.
s.url = s.url.toString().replace( rhash, "" );
// Use original (not extended) context object if it was provided // Use original (not extended) context object if it was provided
s.context = origSettings && origSettings.context != null ? origSettings.context : s; s.context = origSettings && origSettings.context != null ? origSettings.context : s;

10
test/unit/ajax.js
View file

@ -1350,6 +1350,16 @@ test("jQuery.ajax - active counter", function() {
ok( jQuery.active == 0, "ajax active counter should be zero: " + jQuery.active ); ok( jQuery.active == 0, "ajax active counter should be zero: " + jQuery.active );
}); });
test( "jQuery.ajax - Location object as url (#7531)", 1, function () {
var success = false;
try {
var xhr = jQuery.ajax({ url: document.location });
success = true;
xhr.abort();
} catch (e) {}
ok( success, "document.location did not generate exception" );
});
} }