deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed a bug in clone where it wouldn't work on an XML node in IE. Also added unit test for it.

Browse source
This commit is contained in:
David Serduke 2007-12-12 01:32:35 +00:00
parent c6a44c7943
commit 279f77e960
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core.js
View file

@ -290,7 +290,7 @@ jQuery.fn = jQuery.prototype = {
clone: function( events ) { clone: function( events ) {
// Do the clone // Do the clone
var ret = this.map(function(){ var ret = this.map(function(){
if ( jQuery.browser.msie ) { if ( jQuery.browser.msie && !jQuery.isXMLDoc(this) ) {
// IE copies events bound via attachEvent when // IE copies events bound via attachEvent when
// using cloneNode. Calling detachEvent on the // using cloneNode. Calling detachEvent on the
// clone will also remove the events from the orignal // clone will also remove the events from the orignal

12
test/unit/core.js
View file

@ -864,7 +864,7 @@ test("find(String)", function() {
}); });
test("clone()", function() { test("clone()", function() {
expect(4); expect(6);
ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' ); ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' );
var clone = $('#yahoo').clone(); var clone = $('#yahoo').clone();
ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' ); ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' );
@ -872,6 +872,16 @@ test("clone()", function() {
// using contents will get comments regular, text, and comment nodes // using contents will get comments regular, text, and comment nodes
var cl = $("#nonnodes").contents().clone(); var cl = $("#nonnodes").contents().clone();
ok( cl.length >= 2, "Check node,textnode,comment clone works (some browsers delete comments on clone)" ); ok( cl.length >= 2, "Check node,textnode,comment clone works (some browsers delete comments on clone)" );
stop();
$.get("data/dashboard.xml", function (xml) {
var root = $(xml.documentElement).clone();
$("tab:first", xml).text("origval");
$("tab:first", root).text("cloneval");
equals($("tab:first", xml).text(), "origval", "Check original XML node was correctly set");
equals($("tab:first", root).text(), "cloneval", "Check cloned XML node was correctly set");
start();
});
}); });
test("is(String)", function() { test("is(String)", function() {