deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Getting window dimensions currently fails in Nokia browsers, causing JS error (and consequently making jQuery Mobile fail to render the page). Based on a tip from Ben Nolan, this fix returns window.screen[width|height] if the other attempts at getting window dimensions fail. On mobile at least, it seems to make sense, and on desktop (assuming this issue would ever show up on desktop), this might be better than returning false or undefined.

Browse source
This commit is contained in:
scottjehl 2010-12-22 15:24:07 -05:00
parent 291b1edf44
commit 18fa1fd9da
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/dimensions.js
View file

@ -36,7 +36,7 @@ jQuery.each([ "Height", "Width" ], function( i, name ) {
if ( jQuery.isWindow( elem ) ) {
// Everyone else use document.documentElement or document.body depending on Quirks vs Standards mode
return elem.document.compatMode === "CSS1Compat" && elem.document.documentElement[ "client" + name ] ||
elem.document.body[ "client" + name ];
elem.document.body[ "client" + name ] || window.screen && window.screen[ name ];
// Get document width or height
} else if ( elem.nodeType === 9 ) {