From 18b1cf2942cc082c1c97a2ac9bc33ad77f42d775 Mon Sep 17 00:00:00 2001 From: timmywil Date: Sat, 7 May 2011 22:01:10 -0400 Subject: [PATCH] Remove value check from formHook; other elements can use value hook --- src/attributes.js | 3 --- test/unit/attributes.js | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/attributes.js b/src/attributes.js index 4d164470..c207a001 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -495,9 +495,6 @@ if ( !jQuery.support.getSetAttribute ) { formHook = jQuery.attrHooks.name = jQuery.attrHooks.value = jQuery.valHooks.button = { get: function( elem, name ) { var ret; - if ( name === "value" && !jQuery.nodeName( elem, "button" ) ) { - return elem.getAttribute( name ); - } ret = elem.getAttributeNode( name ); // Return undefined if nodeValue is empty string return ret && ret.nodeValue !== "" ? diff --git a/test/unit/attributes.js b/test/unit/attributes.js index 37e93d0a..ce7775d1 100644 --- a/test/unit/attributes.js +++ b/test/unit/attributes.js @@ -144,7 +144,7 @@ test("attr(Hash)", function() { }); test("attr(String, Object)", function() { - expect(58); + expect(59); var div = jQuery("div").attr("foo", "bar"), fail = false; @@ -244,6 +244,8 @@ test("attr(String, Object)", function() { table.attr("cellspacing", "2"); equals( table[0].cellSpacing, "2", "Check cellspacing is correctly set" ); + equals( jQuery("#area1").attr("value"), undefined, "Value attribute retrieved correctly on textarea." ); + // for #1070 jQuery("#name").attr("someAttr", "0"); equals( jQuery("#name").attr("someAttr"), "0", "Set attribute to a string of \"0\"" );