deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure non-left-click events don't bubble. Fixes #3861.

Browse source
This commit is contained in:
Irae Brasil 2010-01-23 11:12:26 -05:00 committed by jeresig
parent 8eef3a4f2c
commit 150e44cdda
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/event.js
View file

@ -864,6 +864,11 @@ function liveHandler( event ) {
related, match, fn, elem, j, i, l, data,
live = jQuery.extend({}, jQuery.data( this, "events" ).live);
// Make sure we avoid non-left-click bubbling in Firefox (#3861)
if ( event.button && event.type === "click" ) {
return;
}
for ( j in live ) {
fn = live[j];
if ( fn.live === event.type ||

9
test/unit/event.js
View file

@ -608,7 +608,7 @@ test("toggle(Function, Function, ...)", function() {
});
test(".live()/.die()", function() {
expect(61);
expect(62);
var submit = 0, div = 0, livea = 0, liveb = 0;
@ -675,6 +675,13 @@ test(".live()/.die()", function() {
equals( livea, 6, "stopPropagation Click on inner div" );
equals( liveb, 3, "stopPropagation Click on inner div" );
// Make sure click events only fire with primary click
var event = jQuery.Event("click");
event.button = 1;
jQuery("div#nothiddendiv").trigger(event);
equals( livea, 6, "live secondary click" );
jQuery("div#nothiddendivchild").die("click");
jQuery("div#nothiddendiv").die("click");
jQuery("div").die("click");