deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Only try to get data attributes for a jQuery-wrapped object if it is actually an Element node. Fixes #7524.

Browse source
This commit is contained in:
Colin Snover 2010-12-03 01:19:39 -06:00
parent e1d6edf822
commit 11e52bdaea
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/data.js
View file

@ -138,15 +138,17 @@ jQuery.fn.extend({
if ( typeof key === "undefined" ) {
if ( this.length ) {
var attr = this[0].attributes, name;
data = jQuery.data( this[0] );
for ( var i = 0, l = attr.length; i < l; i++ ) {
name = attr[i].name;
if ( name.indexOf( "data-" ) === 0 ) {
name = name.substr( 5 );
dataAttr( this[0], name, data[ name ] );
if ( this[0].nodeType === 1 ) {
var attr = this[0].attributes, name;
for ( var i = 0, l = attr.length; i < l; i++ ) {
name = attr[i].name;
if ( name.indexOf( "data-" ) === 0 ) {
name = name.substr( 5 );
dataAttr( this[0], name, data[ name ] );
}
}
}
}

5
test/unit/data.js
View file

@ -79,7 +79,7 @@ test("jQuery.data", function() {
});
test(".data()", function() {
expect(4);
expect(5);
var div = jQuery("#foo");
strictEqual( div.data("foo"), undefined, "Make sure that missing result is undefined" );
@ -90,6 +90,9 @@ test(".data()", function() {
var nodiv = jQuery("#unfound");
equals( nodiv.data(), null, "data() on empty set returns null" );
var obj = { foo: "bar" };
equals( jQuery(obj).data(), obj, "Retrieve data object from a wrapped JS object (#7524)" );
})
test(".data(String) and .data(String, Object)", function() {