Fixed #1599 as Brandon suggested to ignore negative values to width and height css. The fix itself is slightly different as it was moved to .css() instead of staying in .attr() like in his patch. I decided there was less chance of incorrect behavior (like if someone had an XML file with a width attribute that could be negative). Also took out some unneeded white space while I was in there.
This commit is contained in:
parent
2ccd2cb36b
commit
0a755f6ab3
3 changed files with 16 additions and 3 deletions
|
@ -194,6 +194,9 @@ jQuery.fn = jQuery.prototype = {
|
|||
},
|
||||
|
||||
css: function( key, value ) {
|
||||
// ignore negative width and height values
|
||||
if ( (key == 'width' || key == 'height') && parseFloat(value) < 0 )
|
||||
value = undefined;
|
||||
return this.attr( key, value, "curCSS" );
|
||||
},
|
||||
|
||||
|
|
|
@ -20,6 +20,7 @@
|
|||
<h2 id="userAgent"></h2>
|
||||
|
||||
<!-- Test HTML -->
|
||||
<div id="nothiddendiv" style="height:1px;background:white;"></div>
|
||||
<dl id="dl" style="display:none;">
|
||||
<div id="main" style="display: none;">
|
||||
<p id="firstp">See <a id="simon1" href="http://simon.incutio.com/archive/2003/03/25/#getElementsBySelector" rel="bookmark">this blog entry</a> for more information.</p>
|
||||
|
|
|
@ -410,6 +410,15 @@ test("jQuery.css(elem, 'height') doesn't clear radio buttons (bug #1095)", funct
|
|||
ok( ! $(":checkbox:last", $checkedtest).attr("checked"), "Check last checkbox still NOT checked." );
|
||||
});
|
||||
|
||||
test("width()", function() {
|
||||
expect(2);
|
||||
|
||||
$("#nothiddendiv").width(30);
|
||||
equals($("#nothiddendiv").width(), 30, "Test set to 30 correctly");
|
||||
$("#nothiddendiv").width(-1); // handle negative numbers by ignoring #1599
|
||||
equals($("#nothiddendiv").width(), 30, "Test negative width ignored");
|
||||
});
|
||||
|
||||
test("text()", function() {
|
||||
expect(1);
|
||||
var expected = "This link has class=\"blog\": Simon Willison's Weblog";
|
||||
|
|
Loading…
Reference in a new issue