deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

.closest() with positional selectors wasn't worked as expected.

Browse source
This commit is contained in:
John Resig 2009-01-10 20:30:03 +00:00
parent b1018cad12
commit 0066ba3f82
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core.js
View file

@ -342,10 +342,12 @@ jQuery.fn = jQuery.prototype = {
}, },
closest: function( selector ) { closest: function( selector ) {
var pos = jQuery.expr.match.POS.test( selector ) ? jQuery(selector) : null;
return this.map(function(){ return this.map(function(){
var cur = this; var cur = this;
while ( cur && cur.ownerDocument ) { while ( cur && cur.ownerDocument ) {
if ( jQuery(cur).is(selector) ) if ( pos ? pos.index(cur) > -1 : jQuery(cur).is(selector) )
return cur; return cur;
cur = cur.parentNode; cur = cur.parentNode;
} }

5
test/unit/core.js
View file

@ -1407,11 +1407,14 @@ test("filter()", function() {
}); });
test("closest()", function() { test("closest()", function() {
expect(4); expect(6);
isSet( jQuery("body").closest("body").get(), q("body"), "closest(body)" ); isSet( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
isSet( jQuery("body").closest("html").get(), q("html"), "closest(html)" ); isSet( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
isSet( jQuery("body").closest("div").get(), [], "closest(div)" ); isSet( jQuery("body").closest("div").get(), [], "closest(div)" );
isSet( jQuery("#main").closest("span,#html").get(), q("html"), "closest(span,#html)" ); isSet( jQuery("#main").closest("span,#html").get(), q("html"), "closest(span,#html)" );
isSet( jQuery("div:eq(1)").closest("div:first").get(), [], "closest(div:first)" );
isSet( jQuery("div").closest("body:first div:last").get(), q("divWithNoTabIndex"), "closest(body:first div:last)" );
}); });
test("not()", function() { test("not()", function() {