Commit graph

157 commits

Author SHA1 Message Date
Alexey Verkhovsky
f389d84453 Fixed a bug: URLs should contain web address, not name 2005-02-19 02:45:28 +00:00
Alexey Verkhovsky
414ed31a58 Converting hyperlinks to link_to calls (now that we have Routes, they work) 2005-02-18 23:19:42 +00:00
Alexey Verkhovsky
a9304d35fb Simplified some code in wiki_content.rb 2005-02-18 14:21:17 +00:00
Alexey Verkhovsky
aa95acb4f7 RSS feeds accept query parameter start, end and limit 2005-02-18 02:24:16 +00:00
Alexey Verkhovsky
5e25a94e51 [BREAK BUILD] Upgrade URL rewriting to Routes (there is one test case in routes_test.rb that fails, and it depends on some refactoring that I agreed upon with Ulysses) 2005-02-15 22:41:58 +00:00
Alexey Verkhovsky
9c04ed3461 Rehashed URL generation once again - templates should not use web.make_link anymore, there is link_for_page helper instead 2005-02-13 18:53:49 +00:00
Alexey Verkhovsky
fd1d0ccc1e Better readability for URL generation methods in web.rb 2005-02-13 15:57:58 +00:00
Alexey Verkhovsky
112a21da5c Moved remove_orphaned_pages action to admin controller 2005-02-13 14:58:03 +00:00
Alexey Verkhovsky
2aa1aa8fad Graceful handling of validation errors in edit_web, and a friendly confirmation in case of success 2005-02-10 22:05:30 +00:00
Alexey Verkhovsky
8ab380d6dd Deconflicting a name of an input for two forms on the same page 2005-02-10 21:41:31 +00:00
Alexey Verkhovsky
4e6d2cbdf6 Added validations to edit_web (it could overwrite parameters of an existing Wiki before) 2005-02-10 21:03:50 +00:00
Alexey Verkhovsky
b888799798 Better URL parsing (URIChunk knows more country codes, and is smarter about avoiding messing with Textile markup) 2005-02-05 16:46:26 +00:00
Alexey Verkhovsky
21f7693c06 Fixed links to Wiki pages with slashes and other interesting characters in the name 2005-02-05 16:36:27 +00:00
Alexey Verkhovsky
5cb21ff619 Friendly confirmation message in remove_orphaned_pages 2005-02-05 14:06:50 +00:00
Alexey Verkhovsky
5334fe626a compulsive quote editing 2005-02-05 13:59:43 +00:00
Alexey Verkhovsky
7c28e46688 added JavaScript check for empty password to remove_orphaned_pages action 2005-02-05 13:53:29 +00:00
Alexey Verkhovsky
bc97b8d4f7 enhanced password checking behavior in remove_orphaned_pages;
extracted password error to application
2005-02-05 13:34:12 +00:00
Alexey Verkhovsky
09cfb5635c merged edit_web and update_web into one action 2005-02-05 13:04:55 +00:00
Alexey Verkhovsky
ace569ae05 more regexp caching 2005-02-04 19:00:28 +00:00
Alexey Verkhovsky
9ea307b9d2 cleanup of chunks/engines [Denis] 2005-02-04 18:57:42 +00:00
Alexey Verkhovsky
2ca286971c Web remembers max_upload_size submitted to update_web action (still is not used though) 2005-01-30 06:18:57 +00:00
Alexey Verkhovsky
9a5a195c47 Added max_ulpoad_sze property to web (not used yet), and redesigned edit_web page a little. 2005-01-30 06:11:00 +00:00
Alexey Verkhovsky
5ea3f93bf9 author links on print page are smart about whether they are being exported or just displayed in the browser 2005-01-30 05:33:05 +00:00
Alexey Verkhovsky
c99d675780 web attribute accessed directly, not through accessor. Reason: not to scratch head about "who is web?" 2005-01-30 05:22:19 +00:00
Alexey Verkhovsky
d80d60243b Some more accesskeys [kjell] 2005-01-30 05:12:01 +00:00
Alexey Verkhovsky
85bc93984d Page will try to render itself in revise method, and behave appropriately if markup engine fails [inspired by Denis] 2005-01-30 04:50:41 +00:00
Alexey Verkhovsky
a0303d1eea Search 2005-01-30 03:17:02 +00:00
Alexey Verkhovsky
3c1990a42a Not all incarnations of pdflatex know the --output-directory option [Denis] 2005-01-30 02:56:03 +00:00
Alexey Verkhovsky
63cf09059b Merged new_web action into create_web 2005-01-28 03:44:36 +00:00
Alexey Verkhovsky
16dcdb6e0e A friendly confirmation when a new wiki is set up 2005-01-28 02:57:25 +00:00
Alexey Verkhovsky
22e7104ea1 Error message look slightly better. 2005-01-28 02:44:22 +00:00
Alexey Verkhovsky
83c6eadc0c Merged new_system action into create_system 2005-01-28 02:35:59 +00:00
Alexey Verkhovsky
88e52ab5a9 Extracted AdminController from WikiController 2005-01-28 01:24:31 +00:00
Alexey Verkhovsky
9bc9a29789 corrected a warning prevention condition 2005-01-28 01:00:10 +00:00
Alexey Verkhovsky
785276efc1 bit better error handling in file/import 2005-01-27 04:14:41 +00:00
Alexey Verkhovsky
06daadc7df Reshaped "import wiki" feature from command-line to web interface 2005-01-27 03:55:19 +00:00
Alexey Verkhovsky
3b6566577c Massive change of SVN properties to deal with EOL style problem 2005-01-24 18:52:04 +00:00
Alexey Verkhovsky
b747b611b3 Blocking of file uploads by admin 2005-01-24 01:04:00 +00:00
Alexey Verkhovsky
6c020342a3 explicitly assign all defaults in Web constructor 2005-01-24 00:57:47 +00:00
Alexey Verkhovsky
40ed02c771 anoter well-formedness tweak in edit_web.rhtml 2005-01-24 00:49:31 +00:00
Alexey Verkhovsky
8d8deb8e76 "user interface" to allow or prohibit file uploads (not working, just the UI element) 2005-01-24 00:20:31 +00:00
Alexey Verkhovsky
a99e492f05 corrected a typo 2005-01-23 20:27:24 +00:00
Alexey Verkhovsky
405e81d29d set uploaded files to read-only access mode 2005-01-23 20:26:39 +00:00
Alexey Verkhovsky
12722d1df3 Cleaning up edit_web.rhtml; extracted all the JavaScript to a static file 2005-01-23 19:14:45 +00:00
Alexey Verkhovsky
780891349a explicit action and test for edit_web 2005-01-23 18:30:33 +00:00
Alexey Verkhovsky
a3142c377a prevent password managers from messing up edit_web form 2005-01-23 18:23:27 +00:00
Alexey Verkhovsky
805d4a829e further XML well-formedness fixes 2005-01-23 17:05:28 +00:00
Alexey Verkhovsky
c8e459cbb0 Added a check for XML well-formedness to assert_success
(optional, enabled by uncommenting a variable at the top of test_helper.rb);
corrected some malformed templates (not all yet)
2005-01-23 16:34:27 +00:00
Alexey Verkhovsky
a7bb047424 FileController refreshes references to files/pictures after an upload 2005-01-23 14:54:41 +00:00
Alexey Verkhovsky
44eea43940 uploading pics when not found in the file yard (same as for files) 2005-01-23 13:42:56 +00:00
Alexey Verkhovsky
8263e4bfcd [RESTORES BUILD] Wiki link (in double square brackets) has precedence over autolinking URLs;
contents of wiki links are not passed to markup engines; got rid of bracketing mask method in the 
chunks parser (it was a feature that caused a lot of parsing grief for no good reason)
2005-01-23 05:19:39 +00:00
Alexey Verkhovsky
39f854a11e display images from the file yard 2005-01-23 03:52:07 +00:00
Alexey Verkhovsky
d6fe54f4ad [BREAKS BUILD] Links to pictures. Problem is, URIChunk thinks that index.jpg is a hyperlink to http://index.jp.
Also, commented out the code that was hiding rendering errors. This should be done at a different level.
2005-01-23 03:27:45 +00:00
Alexey Verkhovsky
1d82582c3b Extracted storage of files functionality from controller to an object called FileYard.
There is one file yard per web.
2005-01-23 01:36:51 +00:00
Alexey Verkhovsky
295e41c245 another go at file upload: slightly less naive and _working_ 2005-01-22 19:30:49 +00:00
Alexey Verkhovsky
7dc399650f Added an informational notice (implemented as a flash) to the default layout 2005-01-22 19:24:27 +00:00
Alexey Verkhovsky
aec9449771 Naive implementation of a file upload 2005-01-22 18:38:16 +00:00
Alexey Verkhovsky
e6c32bafc6 Wiki links to files point to the appropriate actions (file, pic) 2005-01-22 16:38:33 +00:00
Alexey Verkhovsky
c30989c7eb Actions that send files to browser smartly determine content-type HTTP header by the file name extnsion 2005-01-22 14:58:43 +00:00
Alexey Verkhovsky
e9a419c40f File download (primitive implementation) 2005-01-22 02:49:52 +00:00
Alexey Verkhovsky
9d90901cd0 URI rewriting to determine a controller based on an action name 2005-01-22 01:57:05 +00:00
Alexey Verkhovsky
12a34823a8 Beginnings of a FileController (serving the file upload feature) 2005-01-22 01:35:00 +00:00
Alexey Verkhovsky
71407f9b9f removed a redundant method from WikiController 2005-01-22 01:15:09 +00:00
Alexey Verkhovsky
26878462f3 Extracted two methods from WikiChunk::Link constructor (it was too long) 2005-01-22 00:54:44 +00:00
Alexey Verkhovsky
92404470e8 Wiki link (square brackets) now knows its type (show, file or pic),
and does not mess up with Textile link hyperlink syntax
2005-01-22 00:39:03 +00:00
Alexey Verkhovsky
87ab5d00ae A bit of golf 2005-01-21 23:00:29 +00:00
Alexey Verkhovsky
661fb64561 more regexp caching 2005-01-21 22:40:16 +00:00
Alexey Verkhovsky
780bf4fe91 a little golf 2005-01-21 22:28:37 +00:00
Alexey Verkhovsky
75b6d30d80 simplified WikiWords.separate 2005-01-21 22:15:29 +00:00
Alexey Verkhovsky
befa8c91b2 reduced the number of warnings in unit tests (still very high though) 2005-01-21 22:08:47 +00:00
Alexey Verkhovsky
259a7028e3 cache compiled regexps in constants 2005-01-21 21:58:48 +00:00
Alexey Verkhovsky
9242ad045d fixed the render_to_string hack to live peasefully with the new ActionPack rule that "the first render wins" 2005-01-21 21:06:46 +00:00
Alexey Verkhovsky
f84727c03e explicitly tell to Rails not to render a layout for file download actions (it shouldn't matter, but...) 2005-01-21 19:44:34 +00:00
Alexey Verkhovsky
88d7dc832d Setting Content-Type to UTF-8, to be consistent with meta-data in the HTML itself 2005-01-21 19:41:46 +00:00
Alexey Verkhovsky
dce2af06aa Autolink URLs like http://localhost:8000 (anything that has a schema like http:// and looks like a URL), in addition to internet URLs. 2005-01-20 21:34:27 +00:00
Alexey Verkhovsky
7a5aa277bb Corrected a reference to non-existent web method in list.rhtml 2005-01-20 13:35:46 +00:00
Alexey Verkhovsky
dc6c455426 instead of parsing category line by markup engine etc, convert it to /list/?category=XYZ hyperlinks 2005-01-20 13:34:15 +00:00
Alexey Verkhovsky
dfde41e63e tweaked unmasking (no need to create and compile regexps all the time when sub(string, string) is enough 2005-01-20 13:32:37 +00:00
Alexey Verkhovsky
8eb35d4021 [RESTORES BUILD] URI parsing is smart about Instiki images again 2005-01-19 21:09:08 +00:00
Alexey Verkhovsky
e8b2a3c30a moved apply_to from WikiContent to Chunk, so tha UriChunk can override it and decide when it
wants to match a URL and when it doesn't want to the in the way of Textile syntax
2005-01-19 20:29:43 +00:00
Alexey Verkhovsky
02930e20fe preparing UriChunk to a refactoring that will let chunks decide whether they want to match or not
(not merely by specifying a regexp pattern)
2005-01-19 20:17:26 +00:00
Alexey Verkhovsky
dbfe531abb Extracted various computations in the constructor of UriChunk to local methods. 2005-01-19 10:59:52 +00:00
Alexey Verkhovsky
d3b12631dd pre-compile and cache URI regexp 2005-01-19 10:56:46 +00:00
Alexey Verkhovsky
07e43d2dae Streamlined URI parsing [dm1] 2005-01-18 20:31:42 +00:00
Alexey Verkhovsky
b195cd8b74 Footer with links to instiki.org and rubyonrails.org 2005-01-18 01:19:58 +00:00
Alexey Verkhovsky
7c02805102 Unsuccessful save unlocks the page; some tweaks and debug-level logging in in return_to_last_remembered 2005-01-18 00:36:43 +00:00
Alexey Verkhovsky
94292199b2 Corrected a link, and changed it to a link_to method 2005-01-18 00:33:10 +00:00
Alexey Verkhovsky
b9737747f2 Display error message from a flash at the top of the page 2005-01-18 00:27:28 +00:00
Alexey Verkhovsky
73552b36a0 If there is a validation error, save action will redirect to the last known good location and set error message in a flash 2005-01-17 23:17:28 +00:00
Alexey Verkhovsky
5c8b738238 Added test at the service level, to see how well madeleine copes with errors. Looks like it does cope with them. 2005-01-17 22:42:45 +00:00
Alexey Verkhovsky
878a6336fb Page#revise raises ValidationError if a revision is exactly same as the page before 2005-01-17 21:27:38 +00:00
Alexey Verkhovsky
8f5ac3440a All controller actions are covered by tests [main success scenarios only - not really trying to break it yet] 2005-01-17 20:37:06 +00:00
Alexey Verkhovsky
bd8e725578 Added assertions for the response content in pdf action; changed all output file names to include seconds 2005-01-17 18:09:13 +00:00
Alexey Verkhovsky
01c5a65405 Sorted out pdf action 2005-01-17 15:47:43 +00:00
Alexey Verkhovsky
0367f67fba changed tex.rhtml in response to a warning from pdflatex
version: MiKTeX-pdfetex 2.4.1700 (1.20a-rc7.2) (MiKTeX 2.4)
2005-01-17 15:39:06 +00:00
Alexey Verkhovsky
da3c060c89 Non-mutating operations should not be logged. 2005-01-16 23:51:59 +00:00
Alexey Verkhovsky
621b79db55 Tests for WikiService use default WikiService (with Madeleine persistence), not a WikiServiceWithNoPersistence. 2005-01-16 23:17:30 +00:00
Alexey Verkhovsky
ef65e5e78a Fix to ticket 2.
When updating the last page revision in the "continuous revision" case, created_at should be used
instead of Time.now.
2005-01-16 22:27:09 +00:00
Alexey Verkhovsky
da3674770e Moved Page#pretty_revised_on to the view (it is not a model method) 2005-01-16 22:19:28 +00:00
Alexey Verkhovsky
dcf1030aaa Removed an obsoleted method and changed some comments 2005-01-16 19:37:34 +00:00