deac/instiki
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Check existance of a revision and respond with 404 if it doesn't exist.

Browse source
This commit is contained in:
Alexey Verkhovsky 2005-08-11 05:30:20 +00:00
parent 08a66badb9
commit fe868135c4
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/wiki_controller.rb
View file

@ -298,6 +298,9 @@ class WikiController < ApplicationController
def get_page_and_revision def get_page_and_revision
@revision = @page.revisions[@params['rev'].to_i] @revision = @page.revisions[@params['rev'].to_i]
if @revision.nil?
render_text 'Page name is not specified', '404 Not Found'
end
end end
def parse_category def parse_category

5
test/functional/wiki_controller_test.rb
View file

@ -371,6 +371,11 @@ class WikiControllerTest < Test::Unit::TestCase
assert_equal @home.revisions[0], r.template_objects['revision'] assert_equal @home.revisions[0], r.template_objects['revision']
end end
def test_non_existant_revision_of_existing_page
r = process 'revision', 'web' => 'wiki1', 'id' => 'HomePage', 'rev' => '5'
assert_response :missing
end
def test_rollback def test_rollback
# rollback shows a form where a revision can be edited. # rollback shows a form where a revision can be edited.