From e7d080db25f0ffaa4cc6175ad138d444447d8b87 Mon Sep 17 00:00:00 2001 From: Jacques Distler Date: Thu, 17 Jan 2008 03:47:08 -0600 Subject: [PATCH] Slightly More Efficient A slightly more efficient implementation of the above change to form_spam_protection. --- .../form_spam_protection/lib/form_tag_helper_extensions.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vendor/plugins/form_spam_protection/lib/form_tag_helper_extensions.rb b/vendor/plugins/form_spam_protection/lib/form_tag_helper_extensions.rb index 63daec37..46c952da 100644 --- a/vendor/plugins/form_spam_protection/lib/form_tag_helper_extensions.rb +++ b/vendor/plugins/form_spam_protection/lib/form_tag_helper_extensions.rb @@ -9,8 +9,10 @@ module ActionView session[:form_keys] ||= {} form_key = Digest::SHA1.hexdigest(self.object_id.to_s + rand.to_s) session[:form_keys][form_key] = [Time.now, 0] - first = session[:form_keys].values.sort { |a,b| a[0] <=> b[0] } [0] - session[:form_keys].delete(session[:form_keys].index(first)) if session[:form_keys].length > 30 + if session[:form_keys].length > 30 + first = session[:form_keys].values.sort { |a,b| a[0] <=> b[0] } [0] + session[:form_keys].delete(session[:form_keys].index(first)) + end out << domEnkode(form_key) end end