deac/instiki
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Calls to show with unspecified page name cause HTTP 404, not HTTP 500

Browse source
This commit is contained in:
Alexey Verkhovsky 2005-03-26 05:37:04 +00:00
parent 6cceead11c
commit c73db9ff5d
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/wiki_controller.rb
View file

@ -207,7 +207,11 @@ class WikiController < ApplicationController
end end
end end
else else
if not @page_name.nil? and not @page_name.empty?
redirect_to :web => @web_name, :action => 'new', :id => CGI.escape(@page_name) redirect_to :web => @web_name, :action => 'new', :id => CGI.escape(@page_name)
else
render_text 'Page name is not specified', '404 Not Found'
end
end end
end end

8
test/functional/wiki_controller_test.rb
View file

@ -552,6 +552,14 @@ class WikiControllerTest < Test::Unit::TestCase
assert_redirected_to :web => 'wiki1', :action => 'new', :id => 'UnknownPage' assert_redirected_to :web => 'wiki1', :action => 'new', :id => 'UnknownPage'
end end
def test_show_no_page
r = process('show', 'id' => '', 'web' => 'wiki1')
assert_equal 404, r.response_code
r = process('show', 'web' => 'wiki1')
assert_equal 404, r.response_code
end
def test_tex def test_tex
r = process('tex', 'web' => 'wiki1', 'id' => 'HomePage') r = process('tex', 'web' => 'wiki1', 'id' => 'HomePage')