Setting Content-Type to UTF-8, to be consistent with meta-data in the HTML itself

This commit is contained in:
Alexey Verkhovsky 2005-01-21 19:41:46 +00:00
parent e619e575ce
commit 88d7dc832d
2 changed files with 31 additions and 1 deletions

View file

@ -7,6 +7,7 @@ class ApplicationController < ActionController::Base
# implements Instiki's legacy URLs # implements Instiki's legacy URLs
require 'url_rewriting_hack' require 'url_rewriting_hack'
before_filter :set_utf8_http_header
after_filter :remember_location after_filter :remember_location
# For injecting a different wiki model implementation. Intended for use in tests # For injecting a different wiki model implementation. Intended for use in tests
@ -31,7 +32,6 @@ class ApplicationController < ActionController::Base
@@REMEMBER_NOT = ['locked', 'save'] @@REMEMBER_NOT = ['locked', 'save']
def remember_location def remember_location
logger.debug @request.method
if @response.headers['Status'] == '200 OK' if @response.headers['Status'] == '200 OK'
unless @@REMEMBER_NOT.include? action_name or @request.method != :get unless @@REMEMBER_NOT.include? action_name or @request.method != :get
@session[:return_to] = url_for @session[:return_to] = url_for
@ -54,4 +54,8 @@ logger.debug @request.method
end end
end end
def set_utf8_http_header
@response.headers['Content-Type'] = 'text/html; charset=UTF-8'
end
end end

View file

@ -0,0 +1,26 @@
# Unit tests for ApplicationController (the abstract controller class)
require File.dirname(__FILE__) + '/../test_helper'
require 'wiki_controller'
require 'rexml/document'
# Need some concrete class to test the abstract class features
class WikiController; def rescue_action(e) logger.error(e); raise e end; end
class ApplicationTest < Test::Unit::TestCase
def setup
setup_test_wiki
setup_controller_test(WikiController)
end
def tear_down
tear_down_wiki
end
def test_utf8_header
r = process('show', 'web' => 'wiki1', 'id' => 'HomePage')
assert_equal 'text/html; charset=UTF-8', r.headers['Content-Type']
end
end