diff --git a/app/controllers/file_controller.rb b/app/controllers/file_controller.rb index 203fd2d3..aa0dc9aa 100644 --- a/app/controllers/file_controller.rb +++ b/app/controllers/file_controller.rb @@ -18,7 +18,7 @@ class FileController < ApplicationController new_file = @web.wiki_files.create(params['file']) if new_file.valid? flash[:info] = "File '#{@file_name}' successfully uploaded" - redirect_to_page(@page_name) + redirect_to(params['referring_page']) else # pass the file with errors back into the form @file = new_file diff --git a/app/views/file/file.rhtml b/app/views/file/file.rhtml index 3cb0cfcc..f4ab96ec 100644 --- a/app/views/file/file.rhtml +++ b/app/views/file/file.rhtml @@ -1,6 +1,7 @@ <%- @title = "Upload #{h @file_name}" @hide_navigation = false + @referring_page ||= request.env["HTTP_REFERER"] -%> <%= error_messages_for 'file' %> @@ -8,6 +9,7 @@ <% form_tag({ :controller => 'file', :web => @web_name, :action => 'file' }, { 'multipart' => true , 'accept-charset' => 'utf-8' }) do %>
rails-e2e.gif" + "?
", @@ -112,14 +112,15 @@ class FileControllerTest < ActionController::TestCase # updated from post to get - post fails the spam protection (no javascript) # Moron! If substituting GET for POST actually works, you # have much, much bigger problems. - r = get :file, :web => 'wiki1', + r = get :file, :web => 'wiki1', :referring_page => '/wiki1/show/Oak', :file => {:file_name => 'rails-e2e.gif', :content => StringIO.new(picture), :description => 'Rails, end-to-end'} + assert_redirected_to '/wiki1/show/Oak' assert @web.has_file?('rails-e2e.gif') assert_equal(picture, WikiFile.find_by_file_name('rails-e2e.gif').content) PageRenderer.setup_url_generator(StubUrlGenerator.new) - @wiki.revise_page('wiki1', 'HomePage', 'Try [[rails-e2e.gif:pic]] again.', + @wiki.revise_page('wiki1', 'Oak', 'Try [[rails-e2e.gif:pic]] again.', Time.now, 'AnonymousBrave', renderer) assert_equal "Try again.
", renderer.display_content diff --git a/vendor/rails/actionpack/lib/action_controller/response.rb b/vendor/rails/actionpack/lib/action_controller/response.rb index 27860a62..5138717b 100644 --- a/vendor/rails/actionpack/lib/action_controller/response.rb +++ b/vendor/rails/actionpack/lib/action_controller/response.rb @@ -144,7 +144,6 @@ module ActionController # :nodoc: set_content_length! convert_content_type! convert_language! - convert_expires! convert_cookies! end @@ -244,10 +243,6 @@ module ActionController # :nodoc: headers["Content-Language"] = headers.delete("language") if headers["language"] end - def convert_expires! - headers["Expires"] = headers.delete("") if headers["expires"] - end - def convert_cookies! headers['Set-Cookie'] = Array(headers['Set-Cookie']).compact end