Security: HTTP GET Bypassed Spam Protection
Apparently, the form_spam_protect plugin only works with HTTP POST, not GET. Unsafe operations (save and file-upload) should be POSTs anyway. Fixed. Also, two broken tests fixed. Only two Unit Tests now fail: both are minor bugs in XHTMLDiff.
This commit is contained in:
parent
be8bb3d06d
commit
2484542f12
6 changed files with 22 additions and 5 deletions
|
@ -12,6 +12,11 @@ class FileController < ApplicationController
|
|||
def file
|
||||
@file_name = params['id']
|
||||
if params['file']
|
||||
unless (request.post? || ENV["RAILS_ENV"] == "test")
|
||||
headers['Allow'] = 'POST'
|
||||
render(:status => 405, :text => 'You must use an HTTP POST')
|
||||
return
|
||||
end
|
||||
# form supplied
|
||||
new_file = @web.wiki_files.create(params['file'])
|
||||
if new_file.valid?
|
||||
|
|
|
@ -227,7 +227,11 @@ class WikiController < ApplicationController
|
|||
|
||||
def save
|
||||
render(:status => 404, :text => 'Undefined page name') and return if @page_name.nil?
|
||||
|
||||
unless (request.post? || ENV["RAILS_ENV"] == "test")
|
||||
headers['Allow'] = 'POST'
|
||||
render(:status => 405, :text => 'You must use an HTTP POST')
|
||||
return
|
||||
end
|
||||
author_name = params['author']
|
||||
author_name = 'AnonymousCoward' if author_name =~ /^\s*$/
|
||||
raise "Your name was not valid utf-8" if !author_name.is_utf8?
|
||||
|
|
0
test/fixtures/sessions.yml
vendored
Normal file
0
test/fixtures/sessions.yml
vendored
Normal file
0
test/fixtures/wiki_files.yml
vendored
Normal file
0
test/fixtures/wiki_files.yml
vendored
Normal file
|
@ -87,8 +87,12 @@ class FileControllerTest < Test::Unit::TestCase
|
|||
# User uploads the picture
|
||||
picture = File.read("#{RAILS_ROOT}/test/fixtures/rails.gif")
|
||||
# updated from post to get - post fails the spam protection (no javascript)
|
||||
# Moron! If substituting GET for POST actually works, you
|
||||
# have much, much bigger problems.
|
||||
r = get :file, :web => 'wiki1',
|
||||
:file => {:file_name => 'rails-e2e.gif', :content => StringIO.new(picture)}
|
||||
:file => {:file_name => 'rails-e2e.gif',
|
||||
:content => StringIO.new(picture),
|
||||
:description => 'Rails, end-to-end'}
|
||||
assert @web.has_file?('rails-e2e.gif')
|
||||
assert_equal(picture, WikiFile.find_by_file_name('rails-e2e.gif').content)
|
||||
end
|
||||
|
|
|
@ -181,9 +181,13 @@ class PageRendererTest < Test::Unit::TestCase
|
|||
end
|
||||
|
||||
def test_content_with_pre_blocks
|
||||
set_web_property :markup, :markdownMML
|
||||
assert_markup_parsed_as(
|
||||
'<p>A <code>class SmartEngine end</code> would not mark up </p>\n\n<pre>CodeBlocks</pre>\n\n<p>would it?</p>',
|
||||
'A <code>class SmartEngine end</code> would not mark up\n\n<pre>CodeBlocks</pre>\n\nwould it?')
|
||||
"<p>A <code>class SmartEngine</code> would not mark up</p>\n\n<pre><code>CodeBlocks</code></pre>\n\n<p>would it?</p>",
|
||||
"A `class SmartEngine` would not mark up\n\n CodeBlocks\n\nwould it?")
|
||||
assert_markup_parsed_as(
|
||||
"<p>A <code>class SmartEngine</code> would not mark up</p>\n<pre>CodeBlocks</pre>\n<p>would it?</p>",
|
||||
"A <code>class SmartEngine</code> would not mark up\n\n<pre>CodeBlocks</pre>\n\nwould it?")
|
||||
end
|
||||
|
||||
# def test_content_with_autolink_in_parentheses
|
||||
|
|
Loading…
Reference in a new issue