deac/instiki
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

A Real Fix For the "Backslashes in Included Equations" Bug

Browse source 
Ruby's String.sub!(pattern, replacement) routine is fundamentally
broken. But the block version works fine.

Using the broken routine in the Chunk handler was a subtle mistake.
This commit is contained in:
Jacques Distler 2009-01-17 00:28:38 -06:00
parent 294ac909c4
commit 13b7e1d766
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/chunks/chunk.rb
View file

@ -61,7 +61,7 @@ module Chunk
end end
def unmask def unmask
@content.sub!(mask, @unmask_text) @content.sub!(/#{mask}/){|s| s.replace @unmask_text}
end end
def rendered? def rendered?
@ -73,7 +73,7 @@ module Chunk
end end
def revert def revert
@content.sub!(mask, @text) @content.sub!(/#{mask}/){|s| s.replace @text}
# unregister # unregister
@content.delete_chunk(self) @content.delete_chunk(self)
end end