From 07da370d41525cb32637425caf8bcaff885d4fbb Mon Sep 17 00:00:00 2001 From: Jacques Distler Date: Fri, 5 Jun 2009 17:45:57 -0500 Subject: [PATCH] Battle-hardening Fix some bugs in the new redirect/change-name implementation. Not completely bullet-proof, yet (need to deal with Jason's issue), but getting there. --- app/models/wiki_reference.rb | 3 ++- app/views/wiki/edit.rhtml | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/models/wiki_reference.rb b/app/models/wiki_reference.rb index 4c2d027f..5e8ffae5 100644 --- a/app/models/wiki_reference.rb +++ b/app/models/wiki_reference.rb @@ -55,7 +55,8 @@ class WikiReference < ActiveRecord::Base def self.pages_redirected_to(web, page_name) names = [] page = web.page(page_name) - Thread.current[:page_redirects][page.name].each { |name| names = names + self.pages_that_reference(web, name) } + redirected_pages = Thread.current[:page_redirects][page.name] + redirected_pages.each { |name| names = names + self.pages_that_reference(web, name) } if redirected_pages names.uniq end diff --git a/app/views/wiki/edit.rhtml b/app/views/wiki/edit.rhtml index a5498ae7..42621a14 100644 --- a/app/views/wiki/edit.rhtml +++ b/app/views/wiki/edit.rhtml @@ -1,5 +1,5 @@ <%- - @title = "Editing #{CGI.escapeHTML(@page.name)}" + @title = "Editing #{@page.name.escapeHTML}" @content_width = 720 @hide_navigation = true -%> @@ -41,6 +41,7 @@ <%- end -%>