6539009cb5
$ENV{GL_REPO_BASE_ABS} is meant to point to the same directory as
$REPO_BASE, except it is meant to be passed to hooks, ADCs and other
child programs. And since you can't be sure where the child program
starts in, this became an absolute path.
Gradually, however, I started using it wherever I needed an absolute
path (mostly in code that jumps around various directories to do stuff).
Which is silly, because there's no reason $REPO_BASE cannot also be made
an absolute, even if the rc file has a relative path.
So that's what I did now: made $REPO_BASE absolute very early on, and
then systematically changed all uses of the longer form to the shorter
form when appropriate. And so the only thing we now use the longer one
for is to pass to child programs.
(Implementation note: The actual change is not very big, but while I was
about it I decided to make the test suite able to test with an absolute
REPO_BASE also, which is why the commit seems so large.)
----
This all started with a complaint from Damien Regad. He had an
extremely odd setup where his bashrc changed PWD to something other than
$HOME before anything else ran. This caused those two variables to
beceom inconsistent, and he had a 1-line fix he wanted me to apply.
I generally don't like making special fixes for for non-standard setups,
and anyway all he had to do was set the full path to REPO_BASE in the rc
file to get around this. Which is what I told him and he very politely
left it at that.
However, this did get me thinking, and I soon realised I was needlessly
conflating "relative versus absolute" with "able to be passed to child
programs". Fixing that solved his problem also, as a side-effect.
So I guess this is all thanks to Damien!
92 lines
2.5 KiB
Plaintext
92 lines
2.5 KiB
Plaintext
# vim: syn=sh:
|
|
for wr in 0 1
|
|
do
|
|
for bc in 0 1
|
|
do
|
|
cd $TESTDIR
|
|
$TESTDIR/rollback || die "rollback failed"
|
|
editrc GL_WILDREPOS $wr
|
|
editrc GL_BIG_CONFIG $bc
|
|
|
|
# ----------
|
|
|
|
name "fail to set foo.bar"
|
|
echo "
|
|
@leads = u1 u2
|
|
@devs = u1 u2 u3 u4
|
|
|
|
@gbar = bar
|
|
repo @gbar
|
|
RW+ = @leads
|
|
RW = @devs
|
|
config foo.bar = baz
|
|
" | ugc
|
|
expect "remote: git config foo.bar not allowed"
|
|
runremote cat repositories/bar.git/config
|
|
notexpect '^.foo'
|
|
notexpect 'bar = baz'
|
|
|
|
name "update rc file to allow foo.*"
|
|
catrc
|
|
cp ~/1 ~/junk
|
|
perl -pi -e 's/GL_GITCONFIG_KEYS = ""/GL_GITCONFIG_KEYS = "foo\\\\..*"/' ~/junk
|
|
cat ~/junk | runremote dd of=.gitolite.rc
|
|
catrc
|
|
expect "GL_GITCONFIG_KEYS.*foo"
|
|
|
|
name "ok to set foo.bar"
|
|
echo "
|
|
@leads = u1 u2
|
|
@devs = u1 u2 u3 u4
|
|
|
|
@gbar = bar
|
|
repo @gbar
|
|
RW+ = @leads
|
|
RW = @devs
|
|
config foo.bar = baz
|
|
" | ugc -r
|
|
expect "remote: Initialized empty Git repository in $TEST_BASE_FULL/bar.git/"
|
|
notexpect "git config.*not allowed"
|
|
expect_push_ok "master -> master"
|
|
runremote cat $TEST_BASE/bar.git/config
|
|
expect '^.foo'
|
|
expect 'bar = baz'
|
|
|
|
name "fail to set foobar.baz"
|
|
echo "
|
|
@leads = u1 u2
|
|
@devs = u1 u2 u3 u4
|
|
|
|
@gbar = bar
|
|
repo @gbar
|
|
RW+ = @leads
|
|
RW = @devs
|
|
config foo.bar = baz
|
|
config foobar.baz = ooka
|
|
" | ugc -r
|
|
expect "remote: git config foobar.baz not allowed"
|
|
runremote cat $TEST_BASE/bar.git/config
|
|
expect '^.foo'
|
|
expect 'bar = baz'
|
|
notexpect '^.foobar'
|
|
notexpect 'baz = ooka'
|
|
|
|
name "delete foo.bar"
|
|
echo "
|
|
@leads = u1 u2
|
|
@devs = u1 u2 u3 u4
|
|
|
|
@gbar = bar
|
|
repo @gbar
|
|
RW+ = @leads
|
|
RW = @devs
|
|
config foo.bar =
|
|
" | ugc -r
|
|
runremote cat $TEST_BASE/bar.git/config
|
|
expect '^.foo'
|
|
notexpect 'bar = baz'
|
|
|
|
name INTERNAL
|
|
done
|
|
done
|