6539009cb5
$ENV{GL_REPO_BASE_ABS} is meant to point to the same directory as $REPO_BASE, except it is meant to be passed to hooks, ADCs and other child programs. And since you can't be sure where the child program starts in, this became an absolute path. Gradually, however, I started using it wherever I needed an absolute path (mostly in code that jumps around various directories to do stuff). Which is silly, because there's no reason $REPO_BASE cannot also be made an absolute, even if the rc file has a relative path. So that's what I did now: made $REPO_BASE absolute very early on, and then systematically changed all uses of the longer form to the shorter form when appropriate. And so the only thing we now use the longer one for is to pass to child programs. (Implementation note: The actual change is not very big, but while I was about it I decided to make the test suite able to test with an absolute REPO_BASE also, which is why the commit seems so large.) ---- This all started with a complaint from Damien Regad. He had an extremely odd setup where his bashrc changed PWD to something other than $HOME before anything else ran. This caused those two variables to beceom inconsistent, and he had a 1-line fix he wanted me to apply. I generally don't like making special fixes for for non-standard setups, and anyway all he had to do was set the full path to REPO_BASE in the rc file to get around this. Which is what I told him and he very politely left it at that. However, this did get me thinking, and I soon realised I was needlessly conflating "relative versus absolute" with "able to be passed to child programs". Fixing that solved his problem also, as a side-effect. So I guess this is all thanks to Damien! |
||
---|---|---|
.. | ||
keys | ||
out | ||
basic.conf | ||
cleanout-gitolite | ||
install-gitolite | ||
README.mkd | ||
rollback | ||
rollback.server | ||
t-fedora-big-config | ||
t00-initial | ||
t01-repo-groups | ||
t02-user-groups | ||
t03-branch-permissions | ||
t03a-branch-permissions | ||
t04-wild | ||
t04a-wild-all | ||
t04a-wild-students | ||
t05-delegation | ||
t05a-delegation | ||
t05b-delegation-wild | ||
t09-oldtests | ||
t09a-oldtests | ||
t50-sequence-test | ||
t51-personal-branches | ||
t52-deny-create-ref | ||
t53-check-info-expand-output | ||
t54-repo-configs | ||
t55-repo-configs-wild-without-CREATOR | ||
t56-repo-configs-wild-with-CREATOR | ||
t57-daemon-gitweb | ||
t58-daemon-gitweb-wild | ||
t59-repo-not-on-disk | ||
t60-daemon-gitweb-via-setperms | ||
t61-setperms-groups | ||
t62-rule-sequences | ||
t63-perm-cats | ||
t64-write-able | ||
t65-rsync | ||
t67-hub | ||
test-driver.sh | ||
update-gitolite |
notes on the testing setup
In this document:
- terminology
- notes and background
- quick instructions for running the test suite
- instructions for adding new tests
terminology
#define PW "patches welcome!"
#define TODO PW
notes and background
-
all testing is done on one machine, using 2 userids
-
test driver exits on the first failed test; no fancy counting here. (PW).
-
installs are done using "gl-easy-install". As such, this test suite is mainly meant for testing the core (access control) functionality, and will not help you test the install/upgrade parts themselves. Those are a lot more difficult to test in an automated fashion, but luckily they also change infrequently and can easily be tested manually when they do. Errors in those are much more visible too. (PW).
-
the test driver has evolved as new scripts were added; you will see that older scripts are a little less sophisticated.
quick instructions for running the test suite
-
create two brand new user IDs: tester and gitolite-test
- these are hard-coded, sorry. (PW)
- give them some passwords
- allow ssh into gitolite-test in
/etc/ssh/sshd_config
; preferably use a line likeAllowUsers gitolite-test@127.0.0.1
so that no one can ssh in from outside
-
prepare/push a bare clone of gitolite itself on /tmp so that the "tester" userid can grab it painlessly
cd your-gitolite-working-repo git clone --bare $PWD /tmp/gitolite # first time git push -f --all /tmp/gitolite # subsequent times
-
"su" to "tester" and clone/fetch the gitolite source:
cd $HOME; git clone /tmp/gitolite # first time cd gitolite; git fetch origin # subsequent times
-
checkout and "install" the branch you want to test (install from "tester" userid to "gitolite-test" userid). Example, if you want to test "pu" branch:
git checkout -t origin/pu # if needed git checkout -f pu; git reset --hard origin/pu # subsequent times cd t # THIS IS IMPORTANT (patches welcome, or will be fixed eventually!) ./install-gitolite
-
run all or some of the tests
./test-driver.sh # or ./test-driver.sh t51
-
you can also run them through "prove", although to make it work easier with prove, I ended up making the "subtest" numbers be the actual test numbers, making it look like I have over 2000 tests, when in reality I have about 600:
prove ./test-driver.sh # or prove ./test-driver.sh :: t51
instructions for adding new tests
(TODO)