deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

(security) fix bug in pattern to detect path traversal

Browse source 
while we're about it, add the same check to some of the internal
routines, so that commands can also be protected.

finally, just to make sure we don't lose it again in some other fashion,
add a few tests for path traversal...
This commit is contained in:
Sitaram Chamarty 2012-10-05 07:19:59 +05:30
parent 0d371ac957
commit f636ce3ba3
3 changed files with 33 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/gitolite-shell
View file

@ -168,7 +168,7 @@ sub sanity {
my $repo = shift;
_die "'$repo' contains bad characters" if $repo !~ $REPONAME_PATT;
_die "'$repo' ends with a '/'" if $repo =~ m(/$);
_die "'$repo' contains '..'" if $repo =~ m(\.\.$);
_die "'$repo' contains '..'" if $repo =~ m(\.\.);
}
# ----------------------------------------------------------------------