deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

update hook: 'sub check_ref' to prepare for rebel+

Browse source 
factor out the code to check $ref into a sub; will help rebel+, which
wants (horrors!) to restrict based on PATH names too!
This commit is contained in:
Sitaram Chamarty 2009-11-16 19:25:34 +05:30
parent c54d3eabbc
commit e8270e9b72
1 changed files with 39 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/hooks/update
View file

@ -64,22 +64,44 @@ push @allowed_refs, { "$PERSONAL/$ENV{GL_USER}/" => "RW+" } if $PERSONAL;
# we want specific perms to override @all, so they come first # we want specific perms to override @all, so they come first
push @allowed_refs, @ { $repos{$ENV{GL_REPO}}{$ENV{GL_USER}} || [] }; push @allowed_refs, @ { $repos{$ENV{GL_REPO}}{$ENV{GL_USER}} || [] };
push @allowed_refs, @ { $repos{$ENV{GL_REPO}}{'@all'} || [] }; push @allowed_refs, @ { $repos{$ENV{GL_REPO}}{'@all'} || [] };
for my $ar (@allowed_refs)
{ my $refex = '';
my $refex = (keys %$ar)[0];
# refex? sure -- a regex to match a ref against :) # check one ref
next unless $ref =~ /$refex/; sub check_ref {
if ($ar->{$refex} =~ /\Q$perm/)
{ # normally, the $ref will be whatever ref the commit is trying to update
# if log failure isn't important enough to block pushes, get rid of # (like refs/heads/master or whatever). At least one of the refexes that
# all the error checking # pertain to this user must match this ref **and** the corresponding
open my $log_fh, ">>", $ENV{GL_LOG} # permission must also match the action (W or +) being attempted. If none
or die "open log failed: $!\n"; # of them match, the access is denied.
print $log_fh "$ENV{GL_TS} $perm\t" .
substr($oldsha, 0, 14) . "\t" . substr($newsha, 0, 14) . # Notice that the function DIES!!! Any future changes that require more
"\t$ENV{GL_REPO}\t$ref\t$ENV{GL_USER}\t$refex\n"; # work to be done *after* this, even on failure, can start using return
close $log_fh or die "close log failed: $!\n"; # codes etc., but for now we're happy to just die.
exit 0;
my $ref = shift;
for my $ar (@allowed_refs) {
$refex = (keys %$ar)[0];
# refex? sure -- a regex to match a ref against :)
next unless $ref =~ /$refex/;
# as far as *this* ref is concerned we're ok
return if ($ar->{$refex} =~ /\Q$perm/);
} }
die "$perm $ref $ENV{GL_REPO} $ENV{GL_USER} DENIED by fallthru\n";
} }
die "$perm $ref $ENV{GL_REPO} $ENV{GL_USER} DENIED by fallthru\n";
# and in this version, we have only one ref to check
check_ref($ref);
# if we returned at all, the check succeeded, so we log the action and exit 0
# logging note: if log failure isn't important enough to block pushes, get rid
# of all the error checking
open my $log_fh, ">>", $ENV{GL_LOG} or die "open log failed: $!\n";
print $log_fh "$ENV{GL_TS} $perm\t" .
substr($oldsha, 0, 14) . "\t" . substr($newsha, 0, 14) .
"\t$ENV{GL_REPO}\t$ref\t$ENV{GL_USER}\t$refex\n";
close $log_fh or die "close log failed: $!\n";
exit 0;