From b6d6260dbb8f7881f9d1a312fc26aa0e3f7d69de Mon Sep 17 00:00:00 2001 From: Sitaram Chamarty Date: Wed, 28 Nov 2012 06:22:55 +0530 Subject: [PATCH] prevent empty %groups being created in compiled conf this would happen if @all was used but no actual groups were defined, and would in turn cause a parse error on the compiled conf because it now ends with a 'false'. thanks to Jelle Raaijmakers --- src/lib/Gitolite/Conf/Store.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Gitolite/Conf/Store.pm b/src/lib/Gitolite/Conf/Store.pm index 9090999..1d6d8e2 100644 --- a/src/lib/Gitolite/Conf/Store.pm +++ b/src/lib/Gitolite/Conf/Store.pm @@ -156,7 +156,7 @@ sub new_repos { # normal repos my @repos = grep { $_ =~ $REPONAME_PATT and not /^@/ } sort keys %repos; # add in members of repo groups - map { push @repos, keys %{ $groups{$_} } } grep { /^@/ } keys %repos; + map { push @repos, keys %{ $groups{$_} } } grep { /^@/ and $_ ne '@all' } keys %repos; for my $repo ( @{ sort_u( \@repos ) } ) { next unless $repo =~ $REPONAME_PATT; # skip repo patterns