deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

_system() is less verbose

Browse source 
otherwise things like 'gitolite access' print extra junk that is
confusing.
This commit is contained in:
Sitaram Chamarty 2012-03-15 09:15:02 +05:30
parent 6624d35cf9
commit 9a8a86306b
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/Gitolite/Common.pm
View file

@ -105,15 +105,19 @@ sub _chdir {
} }
sub _system { sub _system {
# run system(), catch errors. Be verbose only if $ENV{D} exists. If not,
# exit with <rc of system()> if it applies, else just "exit 1".
if ( system(@_) != 0 ) { if ( system(@_) != 0 ) {
say2 "system @_ failed"; say2 "system @_ failed" if $ENV{D};
if ( $? == -1 ) { if ( $? == -1 ) {
die "failed to execute: $!\n"; die "failed to execute: $!\n" if $ENV{D};
} elsif ( $? & 127 ) { } elsif ( $? & 127 ) {
die "child died with signal " . ( $? & 127 ) . "\n"; die "child died with signal " . ( $? & 127 ) . "\n" if $ENV{D};
} else { } else {
die "child exited with value " . ( $? >> 8 ) . "\n"; die "child exited with value " . ( $? >> 8 ) . "\n" if $ENV{D};
exit ( $? >> 8 );
} }
exit 1;
} }
} }