deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

auth: print permissions for @all also

Browse source 
I don't have a use for "@all" at all (pun not intended!) other than the
"testing" repo, but <teemu dot matilainen at iki dot fi> sent in a patch
to mark those repos with "R" and "W" in the permissions list, and I
started thinking about it.

This could actually be useful if we *differentiated* such access from
normal (explicit username) access.  From the "corporate environment"
angle, it would be nice if a project manager could quickly check if any
of his projects have erroneously been made accessible by @all.

So what we do now is print "@" in the corresponding column if "@all" has
the corresponding access.

Also, when someone has access both as himself *and* via @all, we print
the "@"; printing the "R" or "W" would hide the "@", and wouldn't
correctly satisfy the use case described above.
This commit is contained in:
Sitaram Chamarty 2009-11-25 09:15:36 +05:30
parent 1c786d880a
commit 9a85f5d0d6
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
doc/3-faq-tips-etc.mkd
View file

@ -389,6 +389,7 @@ shell:
R W gitolite-admin R W gitolite-admin
R W indic_web_input R W indic_web_input
R W proxy R W proxy
@ @ testing
R W vkc R W vkc
Note that until this version, we used to put out an ugly `need Note that until this version, we used to put out an ugly `need

4
src/gl-auth-command
View file

@ -67,8 +67,8 @@ unless ($ENV{SSH_ORIGINAL_COMMAND}) {
system("cat", "$GL_ADMINDIR/src/VERSION"); system("cat", "$GL_ADMINDIR/src/VERSION");
print "\ryou have the following permissions:\n\r"; print "\ryou have the following permissions:\n\r";
for my $r (sort keys %repos) { for my $r (sort keys %repos) {
my $perm .= " R" if $repos{$r}{R}{$user}; my $perm .= ( $repos{$r}{R}{'@all'} ? ' @' : ( $repos{$r}{R}{$user} ? ' R' : '' ) );
$perm .= " W" if $repos{$r}{W}{$user}; $perm .= ( $repos{$r}{W}{'@all'} ? ' @' : ( $repos{$r}{W}{$user} ? ' W' : '' ) );
print "$perm\t$r\n\r" if $perm; print "$perm\t$r\n\r" if $perm;
} }
exit 1; exit 1;