deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

retain old file's permissions in wrap_print()

Browse source 
wrap_print() was written to create a new file and rename the old one to
avoid a partially written file being read by other processes.  This has
only been reported for the 'projects.list' file, but I just did it for
all files as a matter of course.

list of files currently written via this function:
gl-creater, gl-perms, description, git-daemon-export-ok, projects.list

However, some people want to do the following:

  - set REPO_UMASK tight (0077, default)
  - manually change the perms to something looser (typically g+rX) for
    specific repos
  - set core.sharedRepository to 0750 (git is documented to honor that
    config if available and to override umask)

Except that core.sharedRepository does not apply to files written by
gitolite and not git itself.  So they would open up their description
files and the next compile would close them again!

This patch prevents this from happening.  If the file already exists, it
maintains the same permissions after the rename.
This commit is contained in:
Sitaram Chamarty 2011-09-02 08:50:06 +05:30
parent 7c8c5a899b
commit 6863dca73a
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gitolite.pm
View file

@ -110,7 +110,9 @@ sub wrap_print {
my $fh = wrap_open(">", "$file.$$"); my $fh = wrap_open(">", "$file.$$");
print $fh @text; print $fh @text;
close($fh) or die "$ABRT close $file failed: $! at ", (caller)[1], " line ", (caller)[2], "\n"; close($fh) or die "$ABRT close $file failed: $! at ", (caller)[1], " line ", (caller)[2], "\n";
my $oldmode = ( (stat $file)[2] );
rename "$file.$$", $file; rename "$file.$$", $file;
chmod $oldmode, $file if $oldmode;
} }
sub slurp { sub slurp {