deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

all: lexical file handles instead of bare

Browse source
This commit is contained in:
Sitaram Chamarty 2009-08-25 09:57:19 +05:30
parent 0b0d95a1ff
commit 66bf4a20f9
3 changed files with 35 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gl-auth-command
View file

@ -99,9 +99,12 @@ die "access denied" unless $repos{$repo}{$perm}{$user};
# ( but first save the reponame; we can save some time later in the hook ) # ( but first save the reponame; we can save some time later in the hook )
$ENV{GL_REPO}=$repo; $ENV{GL_REPO}=$repo;
open(LOG, ">>", "$GL_ADMINDIR/log"); # if log failure isn't important enough to block access, get rid of all the
print LOG "\n", scalar(localtime), " $ENV{SSH_ORIGINAL_COMMAND} $user\n"; # error checking
close(LOG); open my $log_fh, ">>", "$GL_ADMINDIR/log"
or die "open log failed: $!";
print $log_fh "\n", scalar(localtime), " $ENV{SSH_ORIGINAL_COMMAND} $user\n";
close $log_fh or die "close log failed: $!";
$repo = "'$REPO_BASE/$repo.git'"; $repo = "'$REPO_BASE/$repo.git'";
exec("git", "shell", "-c", "$verb $repo"); exec("git", "shell", "-c", "$verb $repo");

44
gl-compile-conf
View file

@ -105,13 +105,13 @@ sub expand_userlist
# "compile" GL conf # "compile" GL conf
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
open(INF, "<", $GL_CONF) open my $conf_fh, "<", $GL_CONF
or die "open GL conf failed: $!"; or die "open conf failed: $!";
# the syntax is fairly simple, so we parse it inline # the syntax is fairly simple, so we parse it inline
my @repos; my @repos;
while (<INF>) while (<$conf_fh>)
{ {
# normalise whitespace; keeps later regexes very simple # normalise whitespace; keeps later regexes very simple
s/=/ = /; s/=/ = /;
@ -170,10 +170,10 @@ while (<INF>)
} }
} }
open(OUT, ">", $GL_CONF_COMPILED) open my $compiled_fh, ">", $GL_CONF_COMPILED
or die "open GL conf compiled failed: $!"; or die "open compiled-conf failed: $!";
print OUT Data::Dumper->Dump([\%repos], [qw(*repos)]); print $compiled_fh Data::Dumper->Dump([\%repos], [qw(*repos)]);
close(OUT); close $compiled_fh or die "close compiled-conf failed: $!";
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
# any new repos created? # any new repos created?
@ -201,26 +201,28 @@ for my $repo (keys %repos)
# "compile" ssh authorized_keys # "compile" ssh authorized_keys
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
open(INF, "<", $ENV{HOME} . "/.ssh/authorized_keys") or die "open old authkeys failed: $!"; open my $authkeys_fh, "<", $ENV{HOME} . "/.ssh/authorized_keys"
open(OUT, ">", $ENV{HOME} . "/.ssh/new_authkeys") or die "open new authkeys failed: $!"; or die "open authkeys failed: $!";
open my $newkeys_fh, ">", $ENV{HOME} . "/.ssh/new_authkeys"
or die "open newkeys failed: $!";
# save existing authkeys minus the GL-added stuff # save existing authkeys minus the GL-added stuff
while (<INF>) while (<$authkeys_fh>)
{ {
print OUT unless (/^# gitosis-lite start/../^# gitosis-lite end/); print $newkeys_fh unless (/^# gitosis-lite start/../^# gitosis-lite end/);
} }
# add our "start" line, each key on its own line (prefixed by command and # add our "start" line, each key on its own line (prefixed by command and
# options, in the standard ssh authorized_keys format), then the "end" line. # options, in the standard ssh authorized_keys format), then the "end" line.
print OUT "# gitosis-lite start\n"; print $newkeys_fh "# gitosis-lite start\n";
my_chdir($GL_KEYDIR); my_chdir($GL_KEYDIR);
for my $pubkey (glob("*.pub")) for my $pubkey (glob("*.pub"))
{ {
my $user = $pubkey; $user =~ s/\.pub$//; my $user = $pubkey; $user =~ s/\.pub$//;
print OUT "command=\"$AUTH_COMMAND $user\",$AUTH_OPTIONS "; print $newkeys_fh "command=\"$AUTH_COMMAND $user\",$AUTH_OPTIONS ";
print OUT `cat $pubkey`; print $newkeys_fh `cat $pubkey`;
} }
print OUT "# gitosis-lite end\n"; print $newkeys_fh "# gitosis-lite end\n";
close(OUT); close $newkeys_fh or die "close newkeys failed: $!";
# check what changes are being made; just a comfort factor # check what changes are being made; just a comfort factor
# system("vim -d ~/.ssh/authorized_keys ~/.ssh/new_authkeys"); # system("vim -d ~/.ssh/authorized_keys ~/.ssh/new_authkeys");
@ -238,10 +240,10 @@ if (-d ".git")
# and if there are any # and if there are any
if (system("git diff --cached --quiet") ) if (system("git diff --cached --quiet") )
{ {
open(COMMIT, "|-", "git commit -F -") open my $commit_ph, "|-", "git commit -F -"
or die "pipe commit failed: $!"; or die "open commit failed: $!";
print COMMIT "keydir changed\n\n"; print $commit_ph "keydir changed\n\n";
print COMMIT `git diff --cached --name-status`; print $commit_ph `git diff --cached --name-status`;
close(COMMIT) or die "close commit failed: $!"; close $commit_ph or die "close commit failed: $!";
} }
} }

14
update-hook.pl
View file

@ -41,12 +41,6 @@ unless (my $ret = do $glrc)
die "couldnt do perms file" unless (my $ret = do $GL_CONF_COMPILED); die "couldnt do perms file" unless (my $ret = do $GL_CONF_COMPILED);
# ----------------------------------------------------------------------------
# definitions specific to this program
# ----------------------------------------------------------------------------
open(LOG, ">>", "$GL_ADMINDIR/log");
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
# start... # start...
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
@ -78,8 +72,12 @@ for my $refex (@$allowed_refs)
{ {
if ($ref =~ /$refex/) if ($ref =~ /$refex/)
{ {
print LOG "$perm: $ENV{GL_USER} $ENV{GL_REPO} $ref $oldsha $newsha\n"; # if log failure isn't important enough to block pushes, get rid of
close (LOG); # all the error checking
open my $log_fh, ">>", "$GL_ADMINDIR/log"
or die "open log failed: $!";
print $log_fh "$perm: $ENV{GL_USER} $ENV{GL_REPO} $ref $oldsha $newsha\n";
close $log_fh or die "close log failed: $!";
exit 0; exit 0;
} }
} }