deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

(minor) move a small chunk of code out of a loop

Browse source
This commit is contained in:
Sitaram Chamarty 2012-09-26 14:58:56 +05:30
parent 6328ec2cbe
commit 2dbaa4d12e
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/lib/Gitolite/Conf/Store.pm
View file

@ -63,12 +63,20 @@ sub add_to_group {
} }
sub set_repolist { sub set_repolist {
@repolist = @_;
@repolist = ();
# ...sanity checks # ...sanity checks
for (@repolist) { for (@_) {
if ( check_subconf_repo_disallowed( $subconf, $_ ) ) {
(my $repo = $_) =~ s/^\@$subconf\./locally modified \@/;
$ignored{$subconf}{$repo} = 1;
next;
}
_warn "explicit '.git' extension ignored for $_.git" if s/\.git$//; _warn "explicit '.git' extension ignored for $_.git" if s/\.git$//;
_die "bad reponame '$_'" if $_ !~ $REPOPATT_PATT; _die "bad reponame '$_'" if $_ !~ $REPOPATT_PATT;
push @repolist, $_;
} }
} }
@ -103,13 +111,6 @@ sub add_rule {
$nextseq++; $nextseq++;
for my $repo (@repolist) { for my $repo (@repolist) {
if ( check_subconf_repo_disallowed( $subconf, $repo ) ) {
my $repo = $repo;
$repo =~ s/^\@$subconf\./locally modified \@/;
$ignored{$subconf}{$repo} = 1;
next;
}
push @{ $repos{$repo}{$user} }, [ $nextseq, $perm, $ref ]; push @{ $repos{$repo}{$user} }, [ $nextseq, $perm, $ref ];
} }
} }