deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

(http) fixed up the first level error reporting even better

Browse source 
see http://permalink.gmane.org/gmane.comp.version-control.git/155787
This commit is contained in:
Sitaram Chamarty 2010-09-08 19:57:11 +05:30
parent 4dd17b96cb
commit 2349afdc78
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/gitolite.pm
View file

@ -241,10 +241,22 @@ sub where_is_rc
$ENV{HOME} = $ENV{GITOLITE_HTTP_HOME}; $ENV{HOME} = $ENV{GITOLITE_HTTP_HOME};
$SIG{__DIE__} = sub { $SIG{__DIE__} = sub {
my $msg = shift; chomp($msg); my $service = ($ENV{SSH_ORIGINAL_COMMAND} =~ /git-receive-pack/ ? 'git-receive-pack' : 'git-upload-pack');
&print_http_headers(); # remote-curl.c requires 200 OK even if you want to report an error my $message = shift; chomp($message);
print "$msg\r\n"; print STDERR "$message\n";
print STDERR "$msg\n";
# format the service response, then the message. With initial
# help from Ilari and then a more detailed email from Shawn...
$service = "# service=$service\n"; $message = "ERR $message\n";
$service = sprintf("%04X", length($service)+4) . "$service"; # no CRLF on this one
$message = sprintf("%04X", length($message)+4) . "$message";
&print_http_headers();
print $service;
print "0000"; # flush-pkt, apparently
print $message;
print STDERR $service;
print STDERR $message;
exit 0; # if it's ok for die_webcgi in git.git/http-backend.c, it's ok for me ;-) exit 0; # if it's ok for die_webcgi in git.git/http-backend.c, it's ok for me ;-)
} }
} }