abort on suspicious ref names

(and the other Dan Carpenter finding too, while we're about it!)

Note that neither of these is an actual issue, (and even less likely now
that gitolite is pure perl and no shell metas used) but it's just
playing safe.
This commit is contained in:
Sitaram Chamarty 2012-03-20 23:51:18 +05:30
parent 999f9cd39d
commit 139c08d3a1
3 changed files with 108 additions and 0 deletions

View file

@ -45,6 +45,10 @@ sub in_http {
}
sub in_ssh {
$ENV{SSH_ORIGINAL_COMMAND} ||= '';
my $soc = $ENV{SSH_ORIGINAL_COMMAND};
$soc =~ s/[\n\r]+/<<newline>>/g;
_die "I don't like newlines in the command: $soc\n" if $ENV{SSH_ORIGINAL_COMMAND} ne $soc;
}
# ----------------------------------------------------------------------