deac/gitolite
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

auth: tighten up 2 regexes; one minor code clarity fix

Browse source
This commit is contained in:
Sitaram Chamarty 2009-08-25 09:21:07 +05:30
parent ebf6300d01
commit 0b0d95a1ff
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gl-auth-command
View file

@ -43,8 +43,8 @@ die "couldnt do perms file" unless (my $ret = do $GL_CONF_COMPILED);
# definitions specific to this program # definitions specific to this program
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
my $R_COMMANDS=qr/git[ -]upload-pack/; my $R_COMMANDS=qr/^git[ -]upload-pack$/;
my $W_COMMANDS=qr/git[ -]receive-pack/; my $W_COMMANDS=qr/^git[ -]receive-pack$/;
my $REPONAME_PATT=qr(^[0-9a-zA-Z][0-9a-zA-Z._/-]*$); # very simple pattern my $REPONAME_PATT=qr(^[0-9a-zA-Z][0-9a-zA-Z._/-]*$); # very simple pattern
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
@ -87,8 +87,9 @@ die "I don't like the look of $repo, sorry!"
# first level permissions check # first level permissions check
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------
# now, knowing the user and repo (which is repo path), we try perms # we know the user and repo; we just need to know what perm he's trying
my $perm = 'W'; $perm = 'R' if $verb =~ $R_COMMANDS; my $perm = ($verb =~ $R_COMMANDS ? 'R' : 'W');
die "access denied" unless $repos{$repo}{$perm}{$user}; die "access denied" unless $repos{$repo}{$perm}{$user};
# ---------------------------------------------------------------------------- # ----------------------------------------------------------------------------