Robb Kidd
16ceae895e
Separate observing of Note and MergeRequests
...
* Move is_assigned? and is_being_xx? methods to IssueCommonality
This is behavior merge requests have in common with issues. Moved
methods to IssueCommonality role. Put specs directly into
merge_request_spec because setup differs for issues and MRs
specifically in the "closed" factory to use.
* Add MergeRequestObserver. Parallels IssueObserver in almost every way.
Ripe for refactoring.
* Rename MailerObserver to NoteObserver
With merge request observing moved out of MailerObserver, all that
was left was Note logic. Renamed to NoteObserver, added tests and
updated application config for new observer names. Refactored
NoteObserver to use the note's author and not rely on current_user.
* Set current_user for MergeRequestObserver
IssueObserver and MergeRequestObserver are the only observers that
need a reference to the current_user that they cannot look up on
the objects they are observing.
2012-10-10 17:59:25 -04:00
Dmitriy Zaporozhets
dda852a0d5
Merge pull request #1629 from riyad/show-notes-indicator-for-commits-and-merge-requests
...
Show numer of notes for commits and merge requests
2012-10-10 01:45:39 -07:00
Riyad Preukschas
6dc8c0eac2
Make MRs also count and display its commits' notes
2012-10-10 01:31:36 +02:00
Riyad Preukschas
eb92813757
Move emoji auto-complete helper to ApplicationHelper
2012-10-10 00:53:42 +02:00
Riyad Preukschas
bbd92e57cb
Add emoji_for_completion helper
2012-10-09 14:47:42 +02:00
Dmitriy Zaporozhets
41e53eb980
Annotated
2012-10-09 11:14:17 +03:00
Andrey Kumanyaev
a4cd738686
tests fix
2012-10-09 04:10:16 +04:00
Nihad Abbasov
61f12da3a5
API: add project snippets listing
2012-10-08 02:13:53 -07:00
Dmitriy Zaporozhets
74213534bc
Fix tests
2012-10-05 17:01:44 +03:00
Robert Speicher
58dad2b954
Remove leftover ref_extractor_spec file
...
Apparently it didn't get removed after the rename to ExtractsPath.
2012-10-04 14:31:11 -04:00
Robert Speicher
3606a14889
ExtractsPath: Use ref_names instead of branches+tags
2012-10-04 14:13:52 -04:00
Valeriy Sizov
e25ddca0c4
Fix bug with branches whose name contains slash
2012-10-04 19:31:31 +03:00
Valery Sizov
9e80d2d4f7
Merge branch 'feature/groups' of dev.gitlabhq.com:gitlabhq
2012-10-03 12:17:48 +00:00
Valeriy Sizov
dc22dd8ade
Factories spec refactoring after #1616
2012-10-03 13:33:31 +03:00
Valeriy Sizov
b5f9d29f55
Merge pull request #1617 from dosire/reject-ssh-keys-that-break-gitolite
...
Reject ssh keys that break gitolite
2012-10-03 03:18:08 -07:00
Robert Speicher
5e3be9cda0
Cache the value of safe_message
...
Also, just for extra paranoia, only call safe_message once in the
decorator methods
Adds specs to make sure it still works
2012-10-02 19:00:41 -04:00
Dmitriy Zaporozhets
d683ce5c10
refactored factory + fixed tests
2012-10-02 18:20:46 +03:00
Dmitriy Zaporozhets
fa3ae24ca7
Group entity. Group has many projects
2012-10-02 18:17:12 +03:00
Valeriy Sizov
c4883ca225
Update linguist and pygments #1602
2012-10-02 16:29:03 +03:00
Valeriy Sizov
bda0a75581
#1585 Api for user creation: rspec
2012-10-02 13:59:22 +03:00
randx
db69836319
Move ProjectHooks from spec/requests to spinach
2012-09-27 23:52:08 +03:00
randx
9cabe04368
tests for: Profile -> History
2012-09-27 23:23:11 +03:00
Robert Speicher
f064c84019
Add nav_link helper to TabHelper
2012-09-26 16:32:26 -04:00
Robert Speicher
aa0c4b77b6
Add current_action? helper
2012-09-26 16:32:26 -04:00
Robert Speicher
afc4a75499
Use Rails.root.join where appropriate
2012-09-26 16:32:26 -04:00
Robert Speicher
7df25e77ac
Speed up request specs a bit
2012-09-26 16:32:26 -04:00
Robert Speicher
2df3b310f9
Rename branches and tags Repo methods to branch_names and tag_names
2012-09-26 16:32:26 -04:00
Robert Speicher
5cea3e576d
Remove atom Dashboard spec that no longer applies
2012-09-26 16:32:26 -04:00
Robert Speicher
67fd743294
Clean up project access spec
2012-09-26 16:32:26 -04:00
Robert Speicher
cf237f1d32
Fix GFM request spec
2012-09-26 16:32:26 -04:00
Robert Speicher
9f0e80591a
Fix Repository role spec
2012-09-26 16:32:25 -04:00
Robert Speicher
1799cf3b49
Add CommitsController spec to make sure atom feeds work
2012-09-26 16:32:25 -04:00
Robert Speicher
6cb626ef51
Add Compare#index and Compare#create actions
...
Create just redirects to our specially-formatted #show action
2012-09-26 16:32:24 -04:00
Robert Speicher
6b90f36f5b
Updates to routing specs
2012-09-26 16:32:24 -04:00
Robert Speicher
60ac6a28a2
Allow current_controller? helper to take an Array of options
2012-09-26 16:32:24 -04:00
Robert Speicher
3ad931ca92
Add current_controller? helper method
...
Simplifies some of the "active tab" checks we're doing
2012-09-26 16:32:23 -04:00
Robert Speicher
f1c6bd8df3
Factories - Format project path and code
2012-09-26 16:32:23 -04:00
Robert Speicher
169f16fb32
Remove Commits#compare, add CompareController
2012-09-26 16:32:22 -04:00
Robert Speicher
a1e68a9120
Rename RefExtractor to ExtractsPath
...
Update docs a bit
2012-09-26 16:32:22 -04:00
Robert Speicher
a8ea8d98a4
Update RefExtractor to handle atom feeds
2012-09-26 16:32:22 -04:00
Robert Speicher
576cec6c67
Add BlobController, remove Refs#blob
2012-09-26 16:32:22 -04:00
Robert Speicher
39c6579306
Add BlameController, remove Refs#blame action
2012-09-26 16:32:22 -04:00
Robert Speicher
37f0b600bc
Another RefExtractor refactor
2012-09-26 16:32:22 -04:00
Robert Speicher
79a02df92e
Update usages of tree_file_project_ref_path to project_tree_path
2012-09-26 16:32:21 -04:00
Robert Speicher
e33cbb9b42
Add TreeController and spec
2012-09-26 16:32:21 -04:00
Robert Speicher
884eb73297
Enable tree resource, remove old tree routes
2012-09-26 16:32:21 -04:00
Robert Speicher
567767bcf2
Add ref_extractor helper module for upcoming controllers
2012-09-26 16:32:21 -04:00
Robert Speicher
b389247c02
Use Commit#show instead of Commits#show to view a single commit
...
Commits#show (plural) is going to be for showing commit history on a
specific path.
2012-09-26 16:32:21 -04:00
Robert Speicher
bde5088525
Add routing specs for new routes
2012-09-26 16:32:20 -04:00
Nihad Abbasov
83efcabc82
set activerecord whitelist_attributes to true
2012-09-26 11:18:35 -07:00