Commit graph

106 commits

Author SHA1 Message Date
Alex Denisov a86bd87afc User joined project event added 2012-09-09 23:18:28 +03:00
Dmitriy Zaporozhets 4f8a4aa44c Merge pull request #1384 from tsigo/emoji
Emoji!
2012-09-06 23:05:18 -07:00
Robert Speicher 8f3b1d6ea4 Fix spec broken by bde19c0 2012-09-06 17:05:23 -04:00
Robert Speicher 2faa4bba40 Update Note#upvote? to support emoji voting 2012-09-06 15:31:25 -04:00
Nihad Abbasov 0b559cdece add validations for boolean attributes 2012-09-05 04:01:11 -07:00
Robert Speicher d29827433d Update User#identifier to conform to Gitolite 2.x's user pattern
Also modifies the specs a bit because I can't help myself.

Closes #480
2012-09-04 00:20:17 -04:00
randx d246a68a24 fix project.last_activity spec 2012-08-30 19:45:05 +03:00
Robert Speicher 97423a0bed Add more coverage for model validations and associations 2012-08-29 11:36:02 -04:00
Robert Speicher 9e7d77cece Remove annotations from specs 2012-08-29 10:44:34 -04:00
Robert Speicher 9d4d40deed Move IssueCommonality and Upvote specs out of models and into their own specs 2012-08-29 10:44:34 -04:00
Robert Speicher 2c95074a5f Remove model specs that are covered by factories_spec 2012-08-29 10:44:34 -04:00
Robert Speicher a3a63eeb92 Remove all instances to 'gitlabhq_x' seed repositories from specs and features
We now need only one seed repo! Also cleans up the seeding script.
2012-08-28 21:22:49 -04:00
Robert Speicher 77d06454ed Simple model spec changes made possible by new factories 2012-08-28 21:22:49 -04:00
Robert Speicher c9c1f76e00 All specs and features currently passing with FactoryGirl 2012-08-28 21:22:49 -04:00
Robert Speicher 580ce4f2d8 Minor cleanup to Milestone model and spec
Back-ported from my still-in-progress major cleanup.
2012-08-25 14:19:16 -04:00
Robert Speicher 852b9c28dd Move observer specs out of spec/models into spec/observers 2012-08-25 13:22:45 -04:00
randx 64f3682feb project should not respond to write_hooks any more 2012-08-21 20:24:04 +03:00
Robert Speicher 7754189187 Fully embrace Ruby 1.9 hash syntax
Didn't bother with files in db/, config/, or features/
2012-08-10 18:25:15 -04:00
Robert Speicher b7f9b8223e Fix search class method for IssueCommonality
Also adds specs to the two affected classes that would have caught my
dumb mistake.
2012-08-09 13:45:12 -04:00
randx 4a437cdf86 Remove useless Protected branch test 2012-08-02 09:05:00 +03:00
Dmitriy Zaporozhets 5926bbac12 Backend Refactoring 2012-07-31 08:32:49 +03:00
tomykaira 03a2995e15 Fix #1009 Replace all special characters in user's identity 2012-07-28 22:05:25 +09:00
Dmitriy Zaporozhets 60ee383eb9 Enable observe for system hooks 2012-07-20 12:08:59 +03:00
Valeriy Sizov 86bd11cbd8 System Hooks: rspec 2012-07-19 00:25:10 +03:00
Valeriy Sizov 655418bed2 System hooks: fix broken tests 2012-07-19 00:25:10 +03:00
Dmitriy Zaporozhets a3bb9ca1fa Feature: Unassigned Merge Requests 2012-07-17 08:19:16 +03:00
Dmitriy Zaporozhets a2eda66b30 Disable issues sort. Recent issues on top. Fixed tests 2012-07-02 21:51:48 +03:00
Dmitriy Zaporozhets 9b337b8328 Epic: Gitlab configuration with default values 2012-07-02 21:51:48 +03:00
Dmitriy Zaporozhets 4c1f435ab7 Merge pull request #971 from gingko/master
Automatic password creation..
2012-06-26 23:41:49 -07:00
Jakub Troszok 4426bc1844 Added option to automaticaly generate passwords for new users. 2012-06-26 23:59:08 +02:00
randx 88c625e3f7 Issues can be unassigned now 2012-06-26 21:47:25 +03:00
randx 6abc649590 Reannotated 2012-06-26 21:23:09 +03:00
Jakub Troszok bea0583951 Added tests for automatic password generation. 2012-06-24 22:51:58 +02:00
Robb Kidd 65989141dc Protect IssueObserver#send_reassigned_email method. 2012-06-20 21:23:05 -04:00
Robb Kidd 88964132ed Extract observation of User to a UserObserver 2012-06-20 14:09:46 -04:00
Robb Kidd 97ca4f5dda Deliver issue mails.
It helps to actually deliver messages.
2012-06-20 14:09:46 -04:00
Robb Kidd dfb5da9da3 Disable observers in specs. Enable only when observer is under test.
Used the built-in observer enable/disable feature in ActiveModel[1].
ActiveRecord::Base includes ActiveModel::Observing which provides this
behavior.

Simple wraps to enable the observer under test were added to the specs
for: ActivityObserver, IssueObserver, Admin::Users and Issues.

The spec for Project.last_activity was refactored to separate the tests
for #last_activity and #last_activity_date. Each had doubles added to
isolate the spec from the hidden dependency on the ActivityObserver
action to create an Event for the project when an Issue is created. This
ActivityObserver behavior is already tested by its spec.

[1] http://api.rubyonrails.org/classes/ActiveModel/ObserverArray.html
2012-06-20 14:09:46 -04:00
Robb Kidd 6617eaaf9b Make IssueObserver handle issus, not MailerObserver 2012-06-20 14:09:46 -04:00
Robb Kidd 356430c3c0 Add method for an issue to know whether it is being closed
Update IssueObserver to create a Note on the issue its being closed.
2012-06-20 14:09:46 -04:00
Robb Kidd 02924de3e1 Add method to Note to create notes about status changes. 2012-06-20 14:09:46 -04:00
Robb Kidd 00ec81eacb Update IssueObserver to send reassigned emails when an issue is reassigned. 2012-06-20 14:09:46 -04:00
Robb Kidd 2416e3cb19 Add new utility method for an issue to know whether it is being reassigned 2012-06-20 14:09:46 -04:00
Robb Kidd f6035552e5 New IssueObserver class and spec.
Handles emails for new issues and reassigned issues.
Need to add creating a Note on Issue close.
2012-06-20 14:09:46 -04:00
Nihad Abbasov faa0ec7c63 cleanup User model 2012-05-29 17:13:41 +05:00
randx 3272620f72 lib/ refactoring. Module Gitlabhq renamed to Gitlab 2012-05-26 13:37:49 +03:00
Robb Kidd d50446088c Add spec for ProtectedBranch. 2012-05-10 22:43:12 +00:00
Dmitriy Zaporozhets 2bad798e11 fixed tests 2012-04-09 01:29:15 +03:00
Dmitriy Zaporozhets d98b183361 first pack of tests for milestones 2012-04-09 01:01:42 +03:00
Dmitriy Zaporozhets 23d950855d Milestone basic scaffold 2012-04-09 00:28:58 +03:00
randx 897da534fa Fix issues with push 600+ commits. refactored, improved push events 2012-04-04 07:39:04 +03:00