Robb Kidd
dfb5da9da3
Disable observers in specs. Enable only when observer is under test.
...
Used the built-in observer enable/disable feature in ActiveModel[1].
ActiveRecord::Base includes ActiveModel::Observing which provides this
behavior.
Simple wraps to enable the observer under test were added to the specs
for: ActivityObserver, IssueObserver, Admin::Users and Issues.
The spec for Project.last_activity was refactored to separate the tests
for #last_activity and #last_activity_date. Each had doubles added to
isolate the spec from the hidden dependency on the ActivityObserver
action to create an Event for the project when an Issue is created. This
ActivityObserver behavior is already tested by its spec.
[1] http://api.rubyonrails.org/classes/ActiveModel/ObserverArray.html
2012-06-20 14:09:46 -04:00
Robb Kidd
5303cc285a
Add resque_spec to test queuing mail.
2012-06-20 14:09:46 -04:00
Robb Kidd
6617eaaf9b
Make IssueObserver handle issus, not MailerObserver
2012-06-20 14:09:46 -04:00
Robb Kidd
356430c3c0
Add method for an issue to know whether it is being closed
...
Update IssueObserver to create a Note on the issue its being closed.
2012-06-20 14:09:46 -04:00
Robb Kidd
02924de3e1
Add method to Note to create notes about status changes.
2012-06-20 14:09:46 -04:00
Robb Kidd
00ec81eacb
Update IssueObserver to send reassigned emails when an issue is reassigned.
2012-06-20 14:09:46 -04:00
Robb Kidd
2416e3cb19
Add new utility method for an issue to know whether it is being reassigned
2012-06-20 14:09:46 -04:00
Robb Kidd
f6035552e5
New IssueObserver class and spec.
...
Handles emails for new issues and reassigned issues.
Need to add creating a Note on Issue close.
2012-06-20 14:09:46 -04:00
Zevs
6507c1085e
Revert "Handle Commit "show suppressed diff" link with a doc-ready event handler."
...
This reverts commit ef1598b4af
2012-06-20 21:01:27 +03:00
Zevs
a9c7de8815
Revert "Handle MR "show all commits" link with a doc-ready event handler."
...
This reverts commit 5b1ede6280
2012-06-20 21:01:00 +03:00
Zevs
581a822326
Revert "Invert "unless .empty?" to "if .present?"; unless-else is evil."
...
This reverts commit 7484bcfff7
2012-06-20 21:00:34 +03:00
Valeriy Sizov
65c35394eb
Merge pull request #951 from robbkidd/remove_link_to_function
...
Replace calls to deprecated link_to_function with doc-ready functions.
2012-06-20 10:43:32 -07:00
randx
4ac0160a11
Hande error with huge commits
2012-06-20 20:08:18 +03:00
Dmitriy Zaporozhets
c7542eb801
Merge pull request #950 from netdata/Create_link_from_keys_count
...
make a hyperlink from the counted keys
2012-06-20 08:29:05 -07:00
Wouter D'Haeseleer
c3d1f2eb9b
make a hyperlink from the counted keys
...
Refs Ticket #948
2012-06-20 17:16:56 +02:00
Robb Kidd
ef1598b4af
Handle Commit "show suppressed diff" link with a doc-ready event handler.
...
Replaces link_to_function use which was deprecated in Rails v3.2.4.
https://github.com/rails/rails/commit/9dc57fe9c
Still absent is a graceful degrade for no-JS.
2012-06-20 11:11:17 -04:00
Dmitriy Zaporozhets
316dfbaea8
Update pygments version
2012-06-20 13:45:26 +03:00
Dmitriy Zaporozhets
2255dc8f8d
Merge pull request #947 from netdata/Update_gemfile_for_latest_grit
...
Update to the latest grit
2012-06-20 02:35:02 -07:00
Wouter D'Haeseleer
13e7ef4b7d
Update Gemfile.lock as well
2012-06-20 11:14:41 +02:00
Wouter D'Haeseleer
5d39f47c4b
Update to the latst grit
...
The latest grit includes a patch for performance improvements.
2012-06-19 22:24:07 +02:00
Dmitriy Zaporozhets
3ca6c960ce
Merge pull request #942 from veprbl/network_graph_fix
...
Network graph fix (#909 )
2012-06-19 06:55:26 -07:00
Dmitry Kalinkin
163395793b
network graph: fixed minor visual artefacts
2012-06-19 17:29:32 +04:00
Dmitry Kalinkin
c31c84f58a
network graph: use same color for all branch
2012-06-19 17:29:32 +04:00
Dmitry Kalinkin
464ca2a248
network graph: change lines to be more github-like (removes some ambiguousness in graph presentation)
2012-06-19 17:29:32 +04:00
Dmitry Kalinkin
efc86f9711
small refactoring for branch-graph.js
2012-06-19 17:29:32 +04:00
Dmitry Kalinkin
f33a80a522
#909 fix network graph json generation
2012-06-19 17:29:31 +04:00
Dmitriy Zaporozhets
25f1a7ec8a
Merge pull request #940 from anoldguy/master
...
Update Fonts to include good Windows Default monospaced font, too.
2012-06-19 04:01:52 -07:00
Nathan Anderson
19a9cd7f9d
Included good default font for Windows.
2012-06-19 07:56:09 -03:00
Nathan Anderson
77860f3537
Included good default for Windows and standardized <pre> font families
2012-06-19 07:55:01 -03:00
Dmitriy Zaporozhets
acdbc1b4c5
Better fonts for code
2012-06-19 13:48:39 +03:00
Valeriy Sizov
e27a1d31e0
Merge pull request #937 from jdamick/master
...
Modified the login screen for primarily LDAP authentication
2012-06-19 01:40:01 -07:00
Robb Kidd
5b1ede6280
Handle MR "show all commits" link with a doc-ready event handler.
...
Replaces link_to_function use which was deprecated in Rails v3.2.4.
https://github.com/rails/rails/commit/9dc57fe9c
Still absent is a graceful degrade for no-JS.
2012-06-18 18:36:25 -04:00
Robb Kidd
7484bcfff7
Invert "unless .empty?" to "if .present?"; unless-else is evil.
2012-06-18 18:32:46 -04:00
randx
034ddb85fe
Assignee filter for issues
2012-06-18 20:50:06 +03:00
randx
2dd17623c9
Refactor code themes
2012-06-18 20:18:14 +03:00
randx
22d6dc2b3b
Cucumber features: Team, SSH keys
2012-06-18 19:34:09 +03:00
jdamick
9a4e5a8bd5
removed dead code from the form
2012-06-18 11:51:17 -04:00
jdamick
26124e40ef
Merge branch 'master' of github.com:jdamick/gitlabhq
2012-06-18 11:48:18 -04:00
jdamick
848b5e99fc
moved the ldap login to its own partial and cleaned up the forms a little bit
2012-06-18 11:45:49 -04:00
jdamick
50dabb5452
customizing the user login screen for primarily ldap authentication
2012-06-18 11:45:49 -04:00
jdamick
f296d27648
moved the ldap login to its own partial and cleaned up the forms a little bit
2012-06-18 11:40:14 -04:00
randx
eb00cb69dd
Test only 1.9.3 on travis
2012-06-17 23:05:33 +03:00
randx
6f398a4dcd
Install charlock for travis
2012-06-17 22:53:40 +03:00
randx
f909e25d1b
Improve gitlab encode method
2012-06-17 22:00:13 +03:00
randx
5ff658a607
no pending cucumber for travis
2012-06-17 19:19:01 +03:00
randx
60db88ad34
Lets change how cucumber run on travis
2012-06-17 18:40:00 +03:00
randx
cd3f55a310
Fix travis
2012-06-17 18:33:13 +03:00
Dmitriy Zaporozhets
dbc7ef21d1
Merge pull request #932 from gitlabhq/cucumber
...
Cucumber
2012-06-16 03:46:14 -07:00
randx
e15a2b9695
Keep network graph pending
2012-06-16 13:45:51 +03:00
randx
67f445afea
fixed type
2012-06-16 13:31:21 +03:00
