Robb Kidd
378fe076b6
Reduce complexity: replace case statement with method lookup.
2012-10-11 13:27:58 -04:00
Dmitriy Zaporozhets
baf94bd732
Merge pull request #1675 from robbkidd/separate_mr_observer
...
Separate observing of Note and MergeRequests
2012-10-11 09:35:21 -07:00
Robb Kidd
d32a5d7eef
Clean up indenting in new observer.
2012-10-11 11:05:13 -04:00
Robb Kidd
16ceae895e
Separate observing of Note and MergeRequests
...
* Move is_assigned? and is_being_xx? methods to IssueCommonality
This is behavior merge requests have in common with issues. Moved
methods to IssueCommonality role. Put specs directly into
merge_request_spec because setup differs for issues and MRs
specifically in the "closed" factory to use.
* Add MergeRequestObserver. Parallels IssueObserver in almost every way.
Ripe for refactoring.
* Rename MailerObserver to NoteObserver
With merge request observing moved out of MailerObserver, all that
was left was Note logic. Renamed to NoteObserver, added tests and
updated application config for new observer names. Refactored
NoteObserver to use the note's author and not rely on current_user.
* Set current_user for MergeRequestObserver
IssueObserver and MergeRequestObserver are the only observers that
need a reference to the current_user that they cannot look up on
the objects they are observing.
2012-10-10 17:59:25 -04:00
Robert Speicher
7d145adf35
Move 'closed' attribute to the row instead of the cell
2012-10-10 13:06:34 -04:00
Robert Speicher
ce6e5f34d5
Remove unused li classes from milestone issue filter
2012-10-10 12:43:59 -04:00
Robert Speicher
ace816354f
Add toggle to show closed issues on Milestones#show
...
Progress on #1167
2012-10-10 12:43:59 -04:00
Riyad Preukschas
81ee69381d
Add links to the note source if the note is mixed in
2012-10-10 12:14:48 +02:00
Riyad Preukschas
fb0279f311
Fix vote counting to only count main target notes (not mixed in ones)
2012-10-10 12:09:45 +02:00
Riyad Preukschas
3f72af9994
Make notes for merge requests include commit notes and add helpers
2012-10-10 12:06:30 +02:00
Dmitriy Zaporozhets
dda852a0d5
Merge pull request #1629 from riyad/show-notes-indicator-for-commits-and-merge-requests
...
Show numer of notes for commits and merge requests
2012-10-10 01:45:39 -07:00
Dmitriy Zaporozhets
60b4c88e3a
Merge pull request #1664 from riyad/auto-complete-everywhere
...
Cleanup auto-completion and add it to all GFM inputs
2012-10-10 01:45:03 -07:00
Riyad Preukschas
6dc8c0eac2
Make MRs also count and display its commits' notes
2012-10-10 01:31:36 +02:00
Riyad Preukschas
77bde9a0e4
Add notes count to commits in lists.
2012-10-10 01:31:36 +02:00
Riyad Preukschas
4d843d2ce1
Fix auto-completion for forms that are inserted with JS
2012-10-10 00:53:57 +02:00
Riyad Preukschas
e4aa5a5c8f
Extract and split GFM auto-completion setup JS
...
* static initialization and setup moved to assets
* per request initialization moved to layout partial
2012-10-10 00:53:55 +02:00
Riyad Preukschas
eb92813757
Move emoji auto-complete helper to ApplicationHelper
2012-10-10 00:53:42 +02:00
Robert Speicher
702133c0e2
Remove unused history_path instance variable
2012-10-09 18:39:03 -04:00
Robert Speicher
cda5e66d7c
Use History.js for better Tree browsing
...
Closes #1578
2012-10-09 18:38:59 -04:00
Riyad Preukschas
682f62fd4a
Mark all GFM capable inputs
2012-10-09 23:06:33 +02:00
randx
679d0d6d76
Context refactoring. Move Issues list, Search logic to context
2012-10-09 22:09:46 +03:00
randx
63fe042d97
project.issues_labels method
2012-10-09 20:39:06 +03:00
Riyad Preukschas
37e579ce10
Redo the auto-completion JS for notes
2012-10-09 14:48:35 +02:00
Riyad Preukschas
3adfbe3e81
Mark inputs for notes with GFM capabilities
2012-10-09 14:48:20 +02:00
Riyad Preukschas
bbd92e57cb
Add emoji_for_completion helper
2012-10-09 14:47:42 +02:00
Dmitriy Zaporozhets
41e53eb980
Annotated
2012-10-09 11:14:17 +03:00
Valeriy Sizov
dc33f71b18
Merge pull request #1656 from zzet/refactoring
...
Refactoring
2012-10-09 01:17:38 -07:00
randx
c348284fed
Reduce count of projects on dashboard to 20
2012-10-09 10:01:07 +03:00
randx
ce1b742b1e
Group: new link on dashboard if admin. Fixed people count
2012-10-09 09:46:20 +03:00
Dmitriy Zaporozhets
26045d7a2c
Merge pull request #1596 from riyad/fix-messages-for-deleted-things
...
Fix messages for deleted things on dashboard
2012-10-08 22:27:25 -07:00
Andrey Kumanyaev
df7c52489a
simple refactoring
2012-10-09 04:10:04 +04:00
Valeriy Sizov
a635b9da97
Revert "Do not allow removal of a project owner user."
...
This reverts commit 927d0cc267
2012-10-08 15:57:30 +03:00
Valeriy Sizov
fc3c0592db
Merge pull request #1651 from dosire/user_can_be_removed_if_its_not_a_project_owner
...
Do not allow removal of a project owner user.
2012-10-08 05:42:47 -07:00
Valeriy Sizov
a9cce9358a
Merge pull request #1627 from tsigo/tree_performance
...
Tree performance improvements
2012-10-08 05:36:31 -07:00
Dmitriy Zaporozhets
bcdb168709
Fix dashboard atom feed routes
2012-10-08 14:17:46 +03:00
Dmitriy Zaporozhets
624abdfc72
Merge branch 'feature/dashboardfeed' of https://github.com/alexleutgoeb/gitlabhq into alexleutgoeb-feature/dashboardfeed
...
Conflicts:
app/decorators/event_decorator.rb
2012-10-08 13:52:07 +03:00
Marin Jankovski
927d0cc267
Do not allow removal of a project owner user.
2012-10-08 12:41:25 +02:00
Dmitriy Zaporozhets
5501955d26
Merge pull request #1636 from dosire/consistent_issue_type_order
...
Reversed order of progress indication so that the text matches the progress bar.
2012-10-07 01:00:38 -07:00
Aaron Stone
7c2e67c660
Tiny fix to the add/edit groups form path field
2012-10-05 23:46:15 -07:00
joseph Borremans
82425cf358
reversed order of progress indication for visual harmony so that text matches the progress bar
2012-10-05 17:48:52 +02:00
Nihad Abbasov
72395d7f6e
no need to add fonts to assets path
2012-10-05 07:23:58 -07:00
Nihad Abbasov
317c928198
improve emoji checking performance
2012-10-05 07:23:58 -07:00
Valeriy Sizov
76c4e83193
Minore code-style fixes
2012-10-04 13:40:40 +03:00
Alex Leutgöb
987e351de7
Escape html entities in commit messages
2012-10-04 10:06:17 +02:00
Dmitriy Zaporozhets
d88332709c
Fixed group issues/mr. Also speedup project list of admin area
2012-10-04 10:51:35 +03:00
Robert Speicher
388d72e6bf
Add render_tree helper; simplify (speed up) tree_icon
2012-10-03 19:39:27 -04:00
Robert Speicher
a8fad4ff9c
Remove locals from tree/submodule_item, use "object" instead
2012-10-03 19:39:27 -04:00
Robert Speicher
37c3474f68
Tree.init() JS is no longer required
2012-10-03 19:39:27 -04:00
Robert Speicher
96b4acf5e7
Remove locals from tree/tree_file and just use "object" instead
2012-10-03 19:39:27 -04:00
Robert Speicher
b5328879f5
Rename tree.js to tree.js.coffee
2012-10-03 19:39:27 -04:00
randx
4f7bd58307
Bigger fonts for groups box
2012-10-03 19:51:14 +03:00
Dmitriy Zaporozhets
f963d37408
Merge pull request #1592 from jouve/devise_layout
...
make devise controllers use devise layout
2012-10-03 07:06:08 -07:00
Valery Sizov
9e80d2d4f7
Merge branch 'feature/groups' of dev.gitlabhq.com:gitlabhq
2012-10-03 12:17:48 +00:00
Dmitriy Zaporozhets
c8412bc9ed
Dont change params hash. Use dup instead
2012-10-03 15:02:02 +03:00
Dmitriy Zaporozhets
ce1b79afa9
SQL Fixes
2012-10-03 14:26:37 +03:00
Dmitriy Zaporozhets
8b76e30656
Spianch test for group dashboard
2012-10-03 13:42:17 +03:00
Valeriy Sizov
b5f9d29f55
Merge pull request #1617 from dosire/reject-ssh-keys-that-break-gitolite
...
Reject ssh keys that break gitolite
2012-10-03 03:18:08 -07:00
Dmitriy Zaporozhets
224fb5770c
Added ability to manage groups from admin
2012-10-03 12:49:43 +03:00
Robert Speicher
5e3be9cda0
Cache the value of safe_message
...
Also, just for extra paranoia, only call safe_message once in the
decorator methods
Adds specs to make sure it still works
2012-10-02 19:00:41 -04:00
Robert Speicher
38ca52f33b
Use branches.length and tags.length instead of [whatever]_count
2012-10-02 18:56:57 -04:00
randx
010ac2b17f
Added back link. cleanup group show page
2012-10-02 22:08:30 +03:00
randx
1b6a3dfec9
Move all stuff to groups controller
2012-10-02 20:42:15 +03:00
Dmitriy Zaporozhets
f9eda9b33a
Group filtering on dashboard
2012-10-02 19:37:53 +03:00
Dmitriy Zaporozhets
d6363e9359
Admin Group scaffold -> new, show, index
2012-10-02 19:01:40 +03:00
Dmitriy Zaporozhets
fa3ae24ca7
Group entity. Group has many projects
2012-10-02 18:17:12 +03:00
Riyad Preukschas
93bc1ff108
Merge branch 'master' into fix-messages-for-deleted-things
2012-10-02 14:04:34 +02:00
Dmitriy Zaporozhets
b82cb2630c
Use class instead id for css styles
2012-10-02 10:26:24 +03:00
Dmitriy Zaporozhets
69751aac32
Refactoring event views
2012-10-01 16:58:13 +03:00
Dmitriy Zaporozhets
663dd6fad6
Refactored events output. Added links to authors of events
2012-10-01 16:39:19 +03:00
Riyad Preukschas
2022ae69df
Clarify deletion messages
2012-09-30 15:04:43 +02:00
Riyad Preukschas
f5a62835bb
Fix completion for per line forms
2012-09-30 12:07:45 +02:00
Riyad Preukschas
6135eeaa3e
Don't link to removed ref
2012-09-30 00:53:21 +02:00
Riyad Preukschas
c2303737ba
Fix double ref_type in push event when removing branch or tag
2012-09-30 00:53:04 +02:00
Cyril
236fd1e63b
all devise controller use devise layout
2012-09-29 13:06:53 +02:00
Dmitriy Zaporozhets
a79eb84289
commit show page styled a bit
2012-09-28 16:05:54 +03:00
randx
7ded8584a5
blue hover
2012-09-27 23:59:41 +03:00
randx
9cabe04368
tests for: Profile -> History
2012-09-27 23:23:11 +03:00
Dmitriy Zaporozhets
68f4b59738
Merge pull request #1569 from jouve/simplify_controllers2
...
Simplify controllers and layout handling
2012-09-27 12:53:01 -07:00
Cyril
be18397d82
rename ProjectController to ProjectResourceController
2012-09-27 20:59:42 +02:00
Robert Speicher
1502be325d
Minor doc fix
2012-09-27 13:12:11 -04:00
randx
308dfc36b8
Fix back button for tree navigation
2012-09-27 19:38:52 +03:00
randx
afecb250a4
Dont show compare link if only one commit in push
2012-09-27 17:13:26 +03:00
Cyril
933c5e4146
update new controllers
2012-09-27 13:44:53 +02:00
Cyril
e563e948bb
Merge branch 'master' into simplify_controllers2
...
Conflicts:
app/controllers/commits_controller.rb
app/controllers/refs_controller.rb
2012-09-27 12:25:52 +02:00
Nihad Abbasov
2088d2eba8
replace ^ and $ anchors in regexp with \A and \z respectively
...
http://guides.rubyonrails.org/security.html#regular-expressions
2012-09-27 02:56:20 -07:00
Nihad Abbasov
c7a1779b22
.map -> .pluck
2012-09-27 02:55:57 -07:00
Nihad Abbasov
841e4fbd08
cosmetical cleanup of models
2012-09-27 02:05:53 -07:00
Nihad Abbasov
2a4359a572
annotate models
2012-09-27 02:05:53 -07:00
Dmitriy Zaporozhets
a8870e87e4
Fix blame markup & breadcrubs for commits
2012-09-27 11:58:41 +03:00
Dmitriy Zaporozhets
2c8d3c33ff
Fixed ref switcher
2012-09-27 09:53:42 +03:00
Dmitriy Zaporozhets
beb324c1c6
Fixed updir method. Fixed breadcrumbs for commits
2012-09-27 09:49:00 +03:00
Robert Speicher
d8f7748dea
Remove app_menu and project_menu partials
...
Now it's consistent across layouts where their main menus are.
2012-09-26 17:00:52 -04:00
Robert Speicher
36f68140d1
Replace various "active tab" checks with nav_link
...
Also remove now-unused tab_class helper
2012-09-26 16:38:28 -04:00
Robert Speicher
f064c84019
Add nav_link helper to TabHelper
2012-09-26 16:32:26 -04:00
Robert Speicher
aa0c4b77b6
Add current_action? helper
2012-09-26 16:32:26 -04:00
Robert Speicher
afc4a75499
Use Rails.root.join where appropriate
2012-09-26 16:32:26 -04:00
Robert Speicher
f8c02f6e39
Add branches and tags Repo methods
...
Simplifies the actions in RepositoriesController
2012-09-26 16:32:26 -04:00
Robert Speicher
2df3b310f9
Rename branches and tags Repo methods to branch_names and tag_names
2012-09-26 16:32:26 -04:00
Robert Speicher
9f0e80591a
Fix Repository role spec
2012-09-26 16:32:25 -04:00
Robert Speicher
e9bd45060e
Fix logs not showing in Tree for the root path
2012-09-26 16:32:25 -04:00
