Merge pull request #1629 from riyad/show-notes-indicator-for-commits-and-merge-requests

Show numer of notes for commits and merge requests
This commit is contained in:
Dmitriy Zaporozhets 2012-10-10 01:45:39 -07:00
commit dda852a0d5
5 changed files with 33 additions and 1 deletions

View file

@ -203,6 +203,11 @@
@extend .cgray; @extend .cgray;
} }
.notes_count {
float:right;
margin: -6px 8px 6px;
}
code { code {
background:#FCEEC1; background:#FCEEC1;
color:$style_color; color:$style_color;

View file

@ -186,6 +186,11 @@ class MergeRequest < ActiveRecord::Base
patch_path patch_path
end end
def mr_and_commit_notes
commit_ids = commits.map(&:id)
Note.where("(noteable_type = 'MergeRequest' AND noteable_id = :mr_id) OR (noteable_type = 'Commit' AND noteable_id IN (:commit_ids))", mr_id: id, commit_ids: commit_ids)
end
end end
# == Schema Information # == Schema Information

View file

@ -13,3 +13,10 @@
= time_ago_in_words(commit.committed_date) = time_ago_in_words(commit.committed_date)
ago ago
&nbsp; &nbsp;
%span.notes_count
- notes = @project.commit_notes(commit) + @project.commit_line_notes(commit)
- if notes.any?
%span.btn.small.disabled.grouped
%i.icon-comment
= notes.count

View file

@ -9,7 +9,7 @@
- if merge_request.notes.any? - if merge_request.notes.any?
%span.btn.small.disabled.grouped %span.btn.small.disabled.grouped
%i.icon-comment %i.icon-comment
= merge_request.notes.count = merge_request.mr_and_commit_notes.count
%span.btn.small.disabled.grouped %span.btn.small.disabled.grouped
= merge_request.source_branch = merge_request.source_branch
&rarr; &rarr;

View file

@ -35,4 +35,19 @@ describe MergeRequest do
it { should include_module(IssueCommonality) } it { should include_module(IssueCommonality) }
it { should include_module(Votes) } it { should include_module(Votes) }
end end
describe "#mr_and_commit_notes" do
let!(:merge_request) { Factory.create(:merge_request) }
before do
merge_request.stub(:commits) { [merge_request.project.commit] }
Factory.create(:note, noteable: merge_request.commits.first)
Factory.create(:note, noteable: merge_request)
end
it "should include notes for commits" do
merge_request.commits.should_not be_empty
merge_request.mr_and_commit_notes.count.should == 2
end
end
end end