deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Reduce the amount of JavaScript written in views

Browse source 
Seeing `:javascript` all over Views feels like a code smell. This goes a
long way towards reducing the amount of JS in views, but there's still
plenty to be done on that front.
This commit is contained in:
Robert Speicher 2012-09-10 02:09:55 -04:00
parent b565f33472
commit d6c384c20f
18 changed files with 22 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/views/snippets/_form.html.haml
View file

@ -16,7 +16,7 @@
.input= f.text_field :file_name, placeholder: "example.rb"
.clearfix
= f.label "Lifetime"
.input= f.select :expires_at, lifetime_select_options, {}, style: "width:200px;"
.input= f.select :expires_at, lifetime_select_options, {}, {class: 'chosen span2'}
.clearfix
= f.label :content, "Code"
.input= f.text_area :content, class: "span8"
@ -26,11 +26,3 @@
= link_to "Cancel", project_snippets_path(@project), class: " btn"
- unless @snippet.new_record?
.right= link_to 'Destroy', [@project, @snippet], confirm: 'Are you sure?', method: :delete, class: "btn right danger delete-snippet", id: "destroy_snippet_#{@snippet.id}"
:javascript
$(function(){
$('select#snippet_expires_at').chosen();
});