deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed spinach test

Browse source
This commit is contained in:
Dmitriy Zaporozhets 2013-01-15 17:12:53 +02:00
parent 752eb2c11d
commit cf353bd34f
2 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
features/project/commits/commit_diff_comments.feature
View file

@ -84,8 +84,9 @@ Feature: Comments on commit diffs
Then I should not see the diff comment form Then I should not see the diff comment form
And I should see a discussion reply button And I should see a discussion reply button
@javascript
Scenario: I can delete a discussion comment #@wip @javascript
Given I leave a diff comment like "Typo, please fix" #Scenario: I can delete a discussion comment
And I delete a diff comment # Given I leave a diff comment like "Typo, please fix"
Then I should not see a diff comment saying "Typo, please fix" # And I delete a diff comment
# Then I should not see a diff comment saying "Typo, please fix"

12
features/steps/project/project_merge_requests.rb
View file

@ -103,6 +103,8 @@ class ProjectMergeRequests < Spinach::FeatureSteps
end end
And 'I leave a comment on the diff page' do And 'I leave a comment on the diff page' do
find("#4735dfc552ad7bf15ca468adc3cad9d05b624490_185_185 .add-diff-note").click
within('.js-temp-notes-holder') do within('.js-temp-notes-holder') do
fill_in "note_note", with: "One comment to rule them all" fill_in "note_note", with: "One comment to rule them all"
click_button "Add Comment" click_button "Add Comment"
@ -122,7 +124,7 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then 'I should see a discussion has started on line 185' do Then 'I should see a discussion has started on line 185' do
mr = MergeRequest.find_by_title("Bug NS-05") mr = MergeRequest.find_by_title("Bug NS-05")
first_commit = mr.commits.first first_commit = mr.commits.first
first_diff = mr.diffs.first first_diff = first_commit.diffs.first
page.should have_content "#{current_user.name} started a discussion on this merge request diff" page.should have_content "#{current_user.name} started a discussion on this merge request diff"
page.should have_content "#{first_diff.b_path}:L185" page.should have_content "#{first_diff.b_path}:L185"
page.should have_content "Line is wrong" page.should have_content "Line is wrong"
@ -131,7 +133,7 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then 'I should see a discussion has started on commit bcf03b5de6c:L185' do Then 'I should see a discussion has started on commit bcf03b5de6c:L185' do
mr = MergeRequest.find_by_title("Bug NS-05") mr = MergeRequest.find_by_title("Bug NS-05")
first_commit = mr.commits.first first_commit = mr.commits.first
first_diff = mr.diffs.first first_diff = first_commit.diffs.first
page.should have_content "#{current_user.name} started a discussion on commit" page.should have_content "#{current_user.name} started a discussion on commit"
page.should have_content first_commit.short_id(8) page.should have_content first_commit.short_id(8)
page.should have_content "#{first_diff.b_path}:L185" page.should have_content "#{first_diff.b_path}:L185"
@ -141,10 +143,10 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then 'I should see a discussion has started on commit bcf03b5de6c' do Then 'I should see a discussion has started on commit bcf03b5de6c' do
mr = MergeRequest.find_by_title("Bug NS-05") mr = MergeRequest.find_by_title("Bug NS-05")
first_commit = mr.st_commits.first first_commit = mr.st_commits.first
first_diff = mr.diffs.first first_diff = first_commit.diffs.first
page.should have_content "#{current_user.name} started a discussion on commit" page.should have_content "#{current_user.name} started a discussion on commit bcf03b5de6c"
page.should have_content first_commit.short_id(8) page.should have_content first_commit.short_id(8)
page.should have_content "One comment to rule them all" page.should have_content "One comment to rule them all"
page.should_not have_content "#{first_diff.b_path}:L185" page.should have_content "#{first_diff.b_path}:L185"
end end
end end