deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

return 404 if project not found

Browse source
This commit is contained in:
Nihad Abbasov 2012-07-25 05:24:28 -07:00
parent f7dd067490
commit cb32e0320a
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/api/helpers.rb
View file

@ -5,8 +5,13 @@ module Gitlab
end
def user_project
@project ||= current_user.projects.find_by_id(params[:id]) ||
current_user.projects.find_by_code(params[:id])
if @project ||= current_user.projects.find_by_id(params[:id]) ||
current_user.projects.find_by_code(params[:id])
else
error!({'message' => '404 Not found'}, 404)
end
@project
end
def authenticate!

6
spec/api/projects_spec.rb
View file

@ -36,6 +36,12 @@ describe Gitlab::API do
response.status.should == 200
json_response['name'].should == project.name
end
it "should return a 404 error if not found" do
get "#{api_prefix}/projects/42?private_token=#{user.private_token}"
response.status.should == 404
json_response['message'].should == '404 Not found'
end
end
describe "GET /projects/:id/repository/branches" do