deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't setuid the repositories (Rake checks)

Browse source
This commit is contained in:
Kevin Lamontagne 2012-12-30 21:46:28 -05:00
parent 29baadf0c7
commit c816dcc105
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/raketasks/maintenance.md
View file

@ -94,7 +94,7 @@ Config directory owned by git:git? ... yes
Config directory access is drwxr-x---? ... yes Config directory access is drwxr-x---? ... yes
Repo base directory exists? ... yes Repo base directory exists? ... yes
Repo base owned by git:git? ... yes Repo base owned by git:git? ... yes
Repo base access is drwsrws---? ... yes Repo base access is drwxrws---? ... yes
Can clone gitolite-admin? ... yes Can clone gitolite-admin? ... yes
Can commit to gitolite-admin? ... yes Can commit to gitolite-admin? ... yes
post-receive hook exists? ... yes post-receive hook exists? ... yes

8
lib/tasks/gitlab/check.rake
View file

@ -693,7 +693,7 @@ namespace :gitlab do
end end
def check_repo_base_permissions def check_repo_base_permissions
print "Repo base access is drwsrws---? ... " print "Repo base access is drwxrws---? ... "
repo_base_path = Gitlab.config.gitolite.repos_path repo_base_path = Gitlab.config.gitolite.repos_path
unless File.exists?(repo_base_path) unless File.exists?(repo_base_path)
@ -701,13 +701,15 @@ namespace :gitlab do
return return
end end
if `stat --printf %a #{repo_base_path}` == "6770" if `stat --printf %a #{repo_base_path}` == "2770"
puts "yes".green puts "yes".green
else else
puts "no".red puts "no".red
puts "#{repo_base_path} is not writable".red puts "#{repo_base_path} is not writable".red
try_fixing_it( try_fixing_it(
"sudo chmod -R ug+rwXs,o-rwx #{repo_base_path}" "sudo chmod -R ug+rwX,o-rwx #{repo_base_path}",
"sudo chmod -R u-s #{repo_base_path}",
"find -type d #{repo_base_path} -print0 | sudo xargs -0 chmod g+s"
) )
for_more_information( for_more_information(
see_installation_guide_section "Gitolite" see_installation_guide_section "Gitolite"