fix mass-assignment error in user create API

This commit is contained in:
Nihad Abbasov 2012-10-19 03:23:10 -07:00
parent 770ec3359d
commit c610206321
2 changed files with 6 additions and 6 deletions

View file

@ -40,7 +40,7 @@ module Gitlab
post do
authenticated_as_admin!
attrs = attributes_for_keys [:email, :name, :password, :password_confirmation, :skype, :linkedin, :twitter, :projects_limit]
user = User.new attrs
user = User.new attrs, as: :admin
if user.save
present user, with: Entities::User
else

View file

@ -4,7 +4,7 @@ describe Gitlab::API do
include ApiHelpers
let(:user) { Factory :user }
let(:admin) {Factory :admin}
let(:admin) { Factory :admin }
let(:key) { Factory :key, user: user }
describe "GET /users" do
@ -42,9 +42,9 @@ describe Gitlab::API do
end
it "should create user" do
expect{
post api("/users", admin), Factory.attributes(:user)
}.to change{User.count}.by(1)
expect {
post api("/users", admin), Factory.attributes(:user, projects_limit: 3)
}.to change { User.count }.by(1)
end
it "shouldn't available for non admin users" do