Handle perfomance issue with team import. Model specs

This commit is contained in:
Dmitriy Zaporozhets 2012-10-24 14:52:17 +03:00
parent fd0aca1225
commit b7a9e41bd2
2 changed files with 55 additions and 9 deletions

View file

@ -22,6 +22,7 @@ class UsersProject < ActiveRecord::Base
class << self
def import_team(source_project, target_project)
UsersProject.without_repository_callback do
UsersProject.transaction do
team = source_project.users_projects.all
@ -37,6 +38,18 @@ class UsersProject < ActiveRecord::Base
end
end
target_project.update_repository
true
rescue
false
end
def without_repository_callback
UsersProject.skip_callback(:destroy, :after, :update_repository)
yield
UsersProject.set_callback(:destroy, :after, :update_repository)
end
def bulk_delete(project, user_ids)
UsersProject.transaction do
UsersProject.where(:user_id => user_ids, :project_id => project.id).each do |users_project|

View file

@ -35,4 +35,37 @@ describe UsersProject do
it { should respond_to(:user_name) }
it { should respond_to(:user_email) }
end
describe :import_team do
before do
@abilities = Six.new
@abilities << Ability
@project_1 = create :project
@project_2 = create :project
@user_1 = create :user
@user_2 = create :user
@project_1.add_access @user_1, :write
@project_2.add_access @user_2, :read
@status = UsersProject.import_team(@project_1, @project_2)
end
it { @status.should be_true }
describe 'project 2 should get user 1 as developer. user_2 should not be changed' do
it { @project_2.users.should include(@user_1) }
it { @project_2.users.should include(@user_2) }
it { @abilities.allowed?(@user_1, :write_project, @project_2).should be_true }
it { @abilities.allowed?(@user_2, :read_project, @project_2).should be_true }
end
describe 'project 1 should not be changed' do
it { @project_1.users.should include(@user_1) }
it { @project_1.users.should_not include(@user_2) }
end
end
end