Auto-merge: 'already can not be merged' alert

This commit is contained in:
Valery Sizov 2012-04-16 23:05:08 +03:00
parent 8269a3a735
commit a8e4f3ed88
4 changed files with 25 additions and 5 deletions

View file

@ -7,7 +7,7 @@ var MergeRequest = {
function(opts) {
this.opts = opts;
if($(".automerge_widget").lenght){
if($(".automerge_widget").length){
$.get(opts.url_to_automerge_check, function(data){
$(".automerge_widget").hide();
$(".automerge_widget." + data.state).show();
@ -48,5 +48,11 @@ var MergeRequest = {
$('.status').removeClass("loading");
},
dataType: "script"});
},
already_cannot_be_merged:
function(){
$(".automerge_widget").hide();
$(".automerge_widget.already_cannot_be_merged").show();
}
}

View file

@ -104,9 +104,13 @@ class MergeRequestsController < ApplicationController
end
def automerge
render_404 unless @merge_request.open? && @merge_request.can_be_merged?
return access_denied! unless can?(current_user, :accept_mr, @project)
@merge_request.automerge!(current_user)
if @merge_request.open? && @merge_request.can_be_merged?
@merge_request.automerge!(current_user)
@status = true
else
@status = false
end
end
def destroy

View file

@ -1,2 +1,7 @@
:plain
location.reload();
-if @status
:plain
location.reload();
-else
:plain
MergeRequest.already_cannot_be_merged()

View file

@ -72,6 +72,11 @@
%p
%strong Checking for ability to automatically merge…
.automerge_widget.already_cannot_be_merged{:style => "display:none"}
.alert-message
%p
%strong This merge request already can not be merged