From d861023cb9dc71b5943916fdd6011dab32085626 Mon Sep 17 00:00:00 2001 From: Nihad Abbasov Date: Thu, 6 Sep 2012 07:52:01 -0700 Subject: [PATCH 1/2] refactor factory specs --- spec/factories_spec.rb | 90 ++---------------------------------------- 1 file changed, 4 insertions(+), 86 deletions(-) diff --git a/spec/factories_spec.rb b/spec/factories_spec.rb index 5760aad4..5ccc17bd 100644 --- a/spec/factories_spec.rb +++ b/spec/factories_spec.rb @@ -1,91 +1,9 @@ require 'spec_helper' -describe "Factories" do - describe 'User' do - it "builds a valid instance" do - build(:user).should be_valid - end - - it "builds a valid admin instance" do - build(:admin).should be_valid - end - end - - describe 'Project' do - it "builds a valid instance" do - build(:project).should be_valid - end - end - - describe 'Issue' do - it "builds a valid instance" do - build(:issue).should be_valid - end - - it "builds a valid closed instance" do - build(:closed_issue).should be_valid - end - end - - describe 'MergeRequest' do - it "builds a valid instance" do - build(:merge_request).should be_valid - end - end - - describe 'Note' do - it "builds a valid instance" do - build(:note).should be_valid - end - end - - describe 'Event' do - it "builds a valid instance" do - build(:event).should be_valid - end - end - - describe 'Key' do - it "builds a valid instance" do - build(:key).should be_valid - end - - it "builds a valid deploy key instance" do - build(:deploy_key).should be_valid - end - - it "builds a valid personal key instance" do - build(:personal_key).should be_valid - end - end - - describe 'Milestone' do - it "builds a valid instance" do - build(:milestone).should be_valid - end - end - - describe 'SystemHook' do - it "builds a valid instance" do - build(:system_hook).should be_valid - end - end - - describe 'ProjectHook' do - it "builds a valid instance" do - build(:project_hook).should be_valid - end - end - - describe 'Wiki' do - it "builds a valid instance" do - build(:wiki).should be_valid - end - end - - describe 'Snippet' do - it "builds a valid instance" do - build(:snippet).should be_valid +FactoryGirl.factories.map(&:name).each do |factory_name| + describe "#{factory_name} factory" do + it 'should be valid' do + build(factory_name).should be_valid end end end From 46b9aafc396278a9ce0732d9a877ca01c45dbc0e Mon Sep 17 00:00:00 2001 From: Nihad Abbasov Date: Thu, 6 Sep 2012 07:56:33 -0700 Subject: [PATCH 2/2] add missing selector to projects.js --- app/assets/javascripts/projects.js.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/projects.js.coffee b/app/assets/javascripts/projects.js.coffee index 7700cf98..85ab2a06 100644 --- a/app/assets/javascripts/projects.js.coffee +++ b/app/assets/javascripts/projects.js.coffee @@ -1,7 +1,7 @@ window.Projects = -> $('#project_name').on 'change', -> slug = slugify $(@).val() - $('#project_code').val slug + $('#project_code, #project_path').val slug $('.new_project, .edit_project').on 'ajax:before', -> $('.project_new_holder, .project_edit_holder').hide()