1/ rspec'ed

2/ @commit.safe_message as an argument
3/ preserve in helper
4/ spaces around operators
This commit is contained in:
Cedric Gatay 2011-12-26 23:22:15 +01:00
parent 5d9f2e7d15
commit 89a03a3453
3 changed files with 78 additions and 10 deletions

View file

@ -20,18 +20,19 @@ module CommitsHelper
def more_commits_link def more_commits_link
offset = params[:offset] || 0 offset = params[:offset] || 0
limit = params[:limit] || 100 limit = params[:limit] || 100
link_to "More", project_commits_path(@project, :offset => offset.to_i + limit.to_i, :limit => limit), link_to "More", project_commits_path(project, :offset => offset.to_i + limit.to_i, :limit => limit),
:remote => true, :class => "lite_button vm", :style => "text-align:center; width:930px; ", :id => "more-commits-link" :remote => true, :class => "lite_button vm", :style => "text-align:center; width:930px; ", :id => "more-commits-link"
end end
def commit_msg_with_link_to_issues def commit_msg_with_link_to_issues(project, message)
out = "" return '' unless message
@commit.safe_message.split(/(#[0-9]+)/m).each do |m| out = ''
message.split(/(#[0-9]+)/m).each do |m|
if m =~ /(#([0-9]+))/m if m =~ /(#([0-9]+))/m
begin begin
issue = Issue.find($2) issue = Issue.find($2)
raise Exception('Issue not belonging to current project, not creating link !') unless issue.project_id == @project.id raise Exception('Issue not belonging to current project, not creating link !') unless issue.project_id == project.id
out+=link_to($1, project_issue_path(@project, $2)) out += link_to($1, project_issue_path(project, $2))
rescue rescue
out += $1 out += $1
end end
@ -39,7 +40,7 @@ module CommitsHelper
out += m out += m
end end
end end
out preserve out
end end
end end

View file

@ -18,7 +18,7 @@
%hr %hr
%pre.commit_message %pre.commit_message
= preserve commit_msg_with_link_to_issues = commit_msg_with_link_to_issues(@project, @commit.safe_message)
.clear .clear
%br %br

View file

@ -0,0 +1,67 @@
require "spec_helper"
include Haml::Helpers
describe CommitsHelper do
before do
@project = Factory :project
@other_project = Factory :project, :path => "OtherPath", :code => "OtherCode"
@fake_user = Factory :user
@valid_issue = Factory :issue, :assignee => @fake_user, :author => @fake_user, :project => @project
@invalid_issue = Factory :issue, :assignee => @fake_user, :author => @fake_user, :project => @other_project
end
it "should provides return message untouched if no issue number present" do
message = "Dummy message without issue number"
commit_msg_with_link_to_issues(@project, message).should eql message
end
it "should returns message handled by preserve" do
message = "My brand new
Commit on multiple
lines !"
#\n are converted to &#x000A as specified in preserve_rspec
expected = "My brand new
 Commit on multiple
 lines !"
commit_msg_with_link_to_issues(@project, message).should eql expected
end
it "should returns empty string if message undefined" do
commit_msg_with_link_to_issues(@project, nil).should eql ''
end
it "should returns link_to issue for one valid issue in message" do
issue_id = @valid_issue.id
message = "One commit message ##{issue_id}"
expected = "One commit message <a href=\"/#{@project.code}/issues/#{issue_id}\">##{issue_id}</a>"
commit_msg_with_link_to_issues(@project, message).should eql expected
end
it "should returns message untouched for one invalid issue in message" do
issue_id = @invalid_issue.id
message = "One commit message ##{issue_id}"
commit_msg_with_link_to_issues(@project, message).should eql message
end
it "should handle multiple issue references in commit message" do
issue_id = @valid_issue.id
invalid_issue_id = @invalid_issue.id
message = "One big commit message with a valid issue ##{issue_id} and an invalid one ##{invalid_issue_id}.
We reference valid ##{issue_id} multiple times (##{issue_id}) as the invalid ##{invalid_issue_id} is also
referenced another time (##{invalid_issue_id})"
expected = "One big commit message with a valid issue <a href=\"/#{@project.code}/issues/#{issue_id}\">##{issue_id}</a>"+
" and an invalid one ##{invalid_issue_id}.&#x000A; "+
"We reference valid <a href=\"/#{@project.code}/issues/#{issue_id}\">##{issue_id}</a> multiple times "+
"(<a href=\"/#{@project.code}/issues/#{issue_id}\">##{issue_id}</a>) "+
"as the invalid ##{invalid_issue_id} is also&#x000A; referenced another time (##{invalid_issue_id})"
commit_msg_with_link_to_issues(@project, message).should eql expected
end
end