deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Preparing 591 for merge. Restyled issues & merge requests. Fixed issue edit.

Browse source
This commit is contained in:
Dmitriy Zaporozhets 2012-03-25 19:05:24 +03:00
parent b1d89f732c
commit 8652cd8989
9 changed files with 79 additions and 89 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
app/assets/stylesheets/common.scss
View file

@ -294,13 +294,7 @@ nav.main_menu {
@include shade; @include shade;
.count { .count {
margin-left:3px; margin-left:3px;
color: #332; color: #aaa;
background: white;
padding: 1px 6px 2px;
font-weight: bold;
-webkit-border-radius: 9px;
-moz-border-radius: 9px;
border-radius: 9px;
} }
.label { .label {
background:$hover; background:$hover;
@ -351,8 +345,8 @@ nav.main_menu {
img.avatar { img.avatar {
float:left; float:left;
margin-right:10px; margin-right:15px;
width:35px; width:40px;
-webkit-border-radius: 4px; -webkit-border-radius: 4px;
-moz-border-radius: 4px; -moz-border-radius: 4px;
border-radius: 4px; border-radius: 4px;
@ -378,7 +372,7 @@ img.lil_av {
.wll { .wll {
background-color: #FFF; background-color: #FFF;
padding: 6px 10px; padding: 10px 5px;
min-height: 20px; min-height: 20px;
border-bottom: 1px solid #eee; border-bottom: 1px solid #eee;
border-bottom: 1px solid rgba(0, 0, 0, 0.05); border-bottom: 1px solid rgba(0, 0, 0, 0.05);
@ -1004,21 +998,8 @@ p.time {
margin: 2px; margin: 2px;
} }
/* Issues Changed */ /* Fix for readme code (stopped it from being yellow) */
/* Could probably rewrite this, a bit sloppy */ .readme {
.well {
.issue_status.span2 {
width:116px;
.alert-message {
width:34px;
margin: 0 0 0 auto;
.error {
width: 40px;
}
}
}
pre { pre {
background: white !important; background: white !important;
@ -1028,8 +1009,13 @@ p.time {
} }
} }
/* Fix for readme code (stopped it from being yellow) */ .issue_box,
.readme { .merge_request_box{
@extend .padded;
@extend .borders;
@extend .prepend-top-20;
@extend .append-bottom-20;
pre { pre {
background: white !important; background: white !important;
@ -1089,7 +1075,7 @@ p.time {
} }
} }
.issue_notes { .new_note {
.input-file { .input-file {
font: 500px monospace; font: 500px monospace;
opacity:0; opacity:0;
@ -1135,4 +1121,4 @@ li.note {
background:url("icon-attachment.png") no-repeat left center; background:url("icon-attachment.png") no-repeat left center;
} }
} }
} }

1
app/assets/stylesheets/tree.scss
View file

@ -175,5 +175,6 @@
float: left; float: left;
position: relative; position: relative;
left: -10px; left: -10px;
padding:0;
} }
} }

8
app/controllers/issues_controller.rb
View file

@ -80,7 +80,13 @@ class IssuesController < ApplicationController
respond_to do |format| respond_to do |format|
format.js format.js
format.html { redirect_to [@project, @issue]} format.html do
if @issue.valid?
redirect_to [@project, @issue]
else
render :edit
end
end
end end
end end

1
app/models/issue.rb
View file

@ -26,7 +26,6 @@ class Issue < ActiveRecord::Base
:length => { :within => 0..255 } :length => { :within => 0..255 }
validates :description, validates :description,
:presence => true,
:length => { :within => 0..2000 } :length => { :within => 0..2000 }
scope :critical, where(:critical => true) scope :critical, where(:critical => true)

2
app/views/issues/_form.html.haml
View file

@ -10,7 +10,7 @@
.clearfix .clearfix
= f.label :title, "Issue Subject" = f.label :title, "Issue Subject"
.input= f.text_field :title, :maxlength => 255 .input= f.text_field :title, :maxlength => 255, :class => "xxlarge"
.clearfix .clearfix
= f.label :description, "Issue Details" = f.label :description, "Issue Details"

49
app/views/issues/show.html.haml
View file

@ -1,9 +1,5 @@
.back_link
= link_to project_issues_path(@project) do
&larr; To issues list
%h3 %h3
#{@issue.title} Issue ##{@issue.id}
%small %small
created at created at
= @issue.created_at.stamp("Aug 21, 2011") = @issue.created_at.stamp("Aug 21, 2011")
@ -22,32 +18,35 @@
- if @issue.upvotes > 0 - if @issue.upvotes > 0
.upvotes#upvotes= "+#{pluralize @issue.upvotes, 'upvote'}" .upvotes#upvotes= "+#{pluralize @issue.upvotes, 'upvote'}"
.back_link
= link_to project_issues_path(@project) do
&larr; To issues list
%hr .issue_box
.merge_request_status_holder
%h5
%div.well
%div.row
%div.issue_meta.span13
%cite.cgray Created by
= image_tag gravatar_icon(@issue.author_email), :width => 16, :class => "lil_av"
%strong.author= link_to_issue_author(@issue)
%cite.cgray and currently assigned to
= image_tag gravatar_icon(@issue.assignee_email), :width => 16, :class => "lil_av"
%strong.author= link_to_issue_assignee(@issue)
%div.issue_status.span2
- if @issue.closed - if @issue.closed
.alert-message.error Closed .alert-message.error.status_info Closed
- else - else
.alert-message.success Open .alert-message.success.status_info Open
= @issue.title
%hr %hr
%div %div
- if @project.description.present? %div.row
= markdown @issue.description %div.issue_meta.span13
%cite.cgray Created by
= image_tag gravatar_icon(@issue.author_email), :width => 16, :class => "lil_av"
%strong.author= link_to_issue_author(@issue)
%cite.cgray and currently assigned to
= image_tag gravatar_icon(@issue.assignee_email), :width => 16, :class => "lil_av"
%strong.author= link_to_issue_assignee(@issue)
%div
- if @issue.description
%hr
= markdown @issue.description
.issue_notes#notes= render "notes/notes", :tid => @issue.id, :tt => "issue" .issue_notes#notes= render "notes/notes", :tid => @issue.id, :tt => "issue"

57
app/views/merge_requests/show.html.haml
View file

@ -16,50 +16,49 @@
= link_to edit_project_merge_request_path(@project, @merge_request), :class => "btn" do = link_to edit_project_merge_request_path(@project, @merge_request), :class => "btn" do
Edit Edit
%br
%small= link_to "Show how to merge", "#", :class => "vlink how_to_merge_link", :title => "How To Merge"
%br %br
- if @merge_request.upvotes > 0 - if @merge_request.upvotes > 0
.upvotes#upvotes= "+#{pluralize @merge_request.upvotes, 'upvote'}" .upvotes#upvotes= "+#{pluralize @merge_request.upvotes, 'upvote'}"
= render "merge_requests/how_to_merge"
.back_link .back_link
= link_to project_merge_requests_path(@project) do = link_to project_merge_requests_path(@project) do
&larr; To merge requests &larr; To merge requests
%hr .merge_request_box
.merge_request_status_holder .merge_request_status_holder
- if @merge_request.closed - if @merge_request.closed
%h5 %h5
.alert-message.error.status_info Closed .alert-message.error.status_info Closed
- if @merge_request.merged? - if @merge_request.merged?
%span %span
Merged by #{@merge_request.merge_event.author_name} Merged by #{@merge_request.merge_event.author_name}
%small #{time_ago_in_words(@merge_request.merge_event.created_at)} ago. %small #{time_ago_in_words(@merge_request.merge_event.created_at)} ago.
- elsif @merge_request.closed_event - elsif @merge_request.closed_event
%span %span
Closed by #{@merge_request.closed_event.author_name} Closed by #{@merge_request.closed_event.author_name}
%small #{time_ago_in_words(@merge_request.closed_event.created_at)} ago. %small #{time_ago_in_words(@merge_request.closed_event.created_at)} ago.
%br %br
- else - else
%h5 %h5
.alert-message.success.status_info Open .alert-message.success.status_info Open
= link_to "How to merge", "#", :class => "vlink how_to_merge_link", :title => "How To Merge" = @merge_request.title
= render "merge_requests/how_to_merge"
%div.well.prettyprint
%div %div
%cite.cgray Created by %div
= image_tag gravatar_icon(@merge_request.author_email), :width => 16, :class => "lil_av" %cite.cgray Created by
%strong.author= link_to_merge_request_author(@merge_request) = image_tag gravatar_icon(@merge_request.author_email), :width => 16, :class => "lil_av"
%strong.author= link_to_merge_request_author(@merge_request)
%cite.cgray and currently assigned to %cite.cgray and currently assigned to
= image_tag gravatar_icon(@merge_request.assignee_email), :width => 16, :class => "lil_av" = image_tag gravatar_icon(@merge_request.assignee_email), :width => 16, :class => "lil_av"
%strong.author= link_to_merge_request_assignee(@merge_request) %strong.author= link_to_merge_request_assignee(@merge_request)
%hr
%div= simple_format @merge_request.title
= render "merge_requests/commits" = render "merge_requests/commits"

4
app/views/notes/_form.html.haml
View file

@ -25,9 +25,9 @@
.span8 .span8
%h5 Attachment: %h5 Attachment:
.clearfix .clearfix
.attachments.breadcrumb .attachments.entry
%div.file_name File name... %div.file_name File name...
%button.file_upload.btn.primary Upload File %button.file_upload.btn.primary.small Upload File
.input= f.file_field :attachment, :class => "input-file" .input= f.file_field :attachment, :class => "input-file"
%span Any file less then 10 MB %span Any file less then 10 MB

2
db/schema.rb
View file

@ -27,7 +27,6 @@ ActiveRecord::Schema.define(:version => 20120323221339) do
create_table "issues", :force => true do |t| create_table "issues", :force => true do |t|
t.string "title" t.string "title"
t.text "description"
t.integer "assignee_id" t.integer "assignee_id"
t.integer "author_id" t.integer "author_id"
t.integer "project_id" t.integer "project_id"
@ -37,6 +36,7 @@ ActiveRecord::Schema.define(:version => 20120323221339) do
t.integer "position", :default => 0 t.integer "position", :default => 0
t.boolean "critical", :default => false, :null => false t.boolean "critical", :default => false, :null => false
t.string "branch_name" t.string "branch_name"
t.text "description"
end end
add_index "issues", ["project_id"], :name => "index_issues_on_project_id" add_index "issues", ["project_id"], :name => "index_issues_on_project_id"