Merge pull request #1300 from tsigo/spec_reorganize

Spec cleanup/reorganization
2012-08-25 13:03:44 -07:00 · 2012-08-25 13:03:44 -07:00 · 79e936e632
commit 79e936e632
parent 6ff0652e9e 580ce4f2d8
22 changed files with 301 additions and 263 deletions
--- a/app/models/milestone.rb
+++ b/app/models/milestone.rb
@ -28,17 +28,9 @@ class Milestone < ActiveRecord::Base
  end

  def percent_complete
-    @percent_complete ||= begin
-                            total_i = self.issues.count
-                            closed_i = self.issues.closed.count
-                            if total_i > 0
-                              (closed_i * 100) / total_i
-                            else
-                              100
-                            end
-                          rescue => ex
-                            0
-                          end
+    ((self.issues.closed.count * 100) / self.issues.count).abs
+  rescue ZeroDivisionError
+    100
  end

  def expires_at