deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

security improved

Browse source
This commit is contained in:
gitlabhq 2011-10-17 13:39:03 +03:00
parent b08e4074b4
commit 783ca89796
9 changed files with 74 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/controllers/issues_controller.rb
View file

@ -1,12 +1,12 @@
class IssuesController < ApplicationController
before_filter :authenticate_user!
before_filter :project
before_filter :issue, :only => [:edit, :update, :destroy, :show]
# Authorize
before_filter :add_project_abilities
before_filter :authorize_read_issue!
before_filter :authorize_write_issue!, :only => [:new, :create, :close, :edit, :update, :sort]
before_filter :authorize_admin_issue!, :only => [:destroy]
respond_to :js
@ -30,12 +30,10 @@ class IssuesController < ApplicationController
end
def edit
@issue = @project.issues.find(params[:id])
respond_with(@issue)
end
def show
@issue = @project.issues.find(params[:id])
@notes = @issue.notes
@note = @project.notes.new(:noteable => @issue)
end
@ -51,7 +49,6 @@ class IssuesController < ApplicationController
end
def update
@issue = @project.issues.find(params[:id])
@issue.update_attributes(params[:issue])
respond_to do |format|
@ -62,7 +59,8 @@ class IssuesController < ApplicationController
def destroy
@issue = @project.issues.find(params[:id])
return access_denied! unless can?(current_user, :admin_issue, @issue)
@issue.destroy
respond_to do |format|
@ -79,4 +77,10 @@ class IssuesController < ApplicationController
render :nothing => true
end
protected
def issue
@issue ||= @project.issues.find(params[:id])
end
end