deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

API: extracted helper method to validate required parameters, code clean up

Browse source 
Added a helper method to check if required parameters are given in an API call. Can be used
to return a `400 Bad Request` return code if a required attribute is missing.
Code clean up and fixed tests.
This commit is contained in:
Sebastian Ziebell 2013-02-27 17:50:30 +01:00
parent 43d7596030
commit 7499f65014
10 changed files with 35 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spec/requests/api/projects_spec.rb
View file

@ -424,10 +424,10 @@ describe Gitlab::API do
end
end
describe "DELETE /projects/:id/hooks/:hook_id" do
describe "DELETE /projects/:id/hooks" do
it "should delete hook from project" do
expect {
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id
}.to change {project.hooks.count}.by(-1)
response.status.should == 200
end
@ -466,7 +466,8 @@ describe Gitlab::API do
response.status.should == 200
json_response.should be_an Array
json_response.first['id'].should == project.repository.commit.id
#json_response.first['id'].should == project.repository.commit.id
json_response.size.should == 1
end
end