deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix GFM helper to raise an exception when @project is not set

Browse source
This commit is contained in:
Riyad Preukschas 2012-08-06 02:32:17 +02:00
parent 90c2cd1ee6
commit 6f9428b1cd
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/helpers/application_helper.rb
View file

@ -44,6 +44,7 @@ module ApplicationHelper
def gfm(text, html_options = {}) def gfm(text, html_options = {})
return text if text.nil? return text if text.nil?
raise "@project is not set" if @project.nil?
# Extract pre blocks # Extract pre blocks
# from http://github.github.com/github-flavored-markdown/ # from http://github.github.com/github-flavored-markdown/

6
spec/helpers/gitlab_flavored_markdown_spec.rb
View file

@ -10,6 +10,12 @@ describe ApplicationHelper do
end end
describe "#gfm" do describe "#gfm" do
it "should raiase an error if @project is not set" do
@project = nil
expect { gfm("foo") }.to raise_error
end
describe "referencing a commit" do describe "referencing a commit" do
it "should link using a full id" do it "should link using a full id" do
gfm("Reverts changes from #{@commit.id}").should == "Reverts changes from #{link_to @commit.id, project_commit_path(@project, :id => @commit.id), :title => "Commit: #{@commit.author_name} - #{@commit.title}", :class => "gfm gfm-commit "}" gfm("Reverts changes from #{@commit.id}").should == "Reverts changes from #{link_to @commit.id, project_commit_path(@project, :id => @commit.id), :title => "Commit: #{@commit.author_name} - #{@commit.title}", :class => "gfm gfm-commit "}"